! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Update search field with selected text
Status:
RESOLVED: FIXED
Product:
Mousepad
Component:
General

Comments

Description Tamaranch 2020-05-10 01:27:23 CEST
Created attachment 9848 
Update search field with selected text

When a portion of text is selected and the search feature invoked by Control-F, the search field in the search bar is initialized with this portion of text.

But if one selects a new portion of text and types again Control-F, the search field is not updated accordingly.
Shouldn't that be changed?

Unless I miss something, the modification would be straightforward.
Comment 1 Matthew Brush editbugs 2020-05-10 03:21:32 CEST
Related to https://bugzilla.xfce.org/show_bug.cgi?id=5905

Also affects the separate "Replace" dialog.
Comment 2 Tamaranch 2020-05-10 12:23:19 CEST
Created attachment 9849 
0001-Update-search-field-with-selected-text.patch

Fixed.
Comment 3 Matthew Brush editbugs 2020-05-10 20:32:24 CEST
Looks ok to me, and tested it's working. I will push it once I have permissions to do so on Gitlab.
Comment 5 Tamaranch 2020-05-10 21:20:23 CEST
I should have created my account on gitlab.xfce.org before, sorry.
I just did it: is it possible to transfer the commit to my new identity : 138-Tamaranch@users.noreply.gitlab.xfce.org

Thanks.
Comment 6 Matthew Brush editbugs 2020-05-11 01:15:45 CEST
> is it possible to transfer the commit to my new identity

As far I know it's not possible without doing a force push.
Comment 7 Tamaranch 2020-05-11 11:06:30 CEST
Well, since this is the very last commit, I think it suffices to do a

git commit --amend --author="Tamaranch <138-Tamaranch@users.noreply.gitlab.xfce.org>"
Comment 8 Tamaranch 2020-05-11 12:06:12 CEST
Oh yes, this is a remote repository, sorry.
So probably not possible without doing a force push, as you said.
It's not a big deal, I've changed my identity for my other currently proposed patches, and I will use the good one in the future.

Bug #16821

Reported by:
Tamaranch
Reported on: 2020-05-10
Last modified on: 2020-05-11

People

Assignee:
Matthew Brush
CC List:
1 user

Version

Target Milestone:
Mousepad 0.4.x

Attachments

Additional information