! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Invisible texts and buttons in xfce4-display-settings
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description Jani Välimaa 2019-05-19 11:20:40 CEST
Created attachment 8538 
Hidden texts and buttons

After update to xfce4-settings 4.13.6 texts and buttons are invisible in xfce4-display-settings. Tried with multiple GTK-themes. Used theme in screenshot is Adwaita-Xfce.
Comment 1 Jani Välimaa 2019-05-19 11:22:55 CEST
Created attachment 8539 
Visible button

Buttons are shown and working when cursor is moved over them.
Comment 2 Olivier Fourdan editbugs 2019-05-19 11:35:26 CEST
Confirmed, I have the same issue, widgets show up once hovered by the pointer...
Comment 3 bittwister 2019-05-19 15:14:24 CEST
And after changing resolution/Apply, log out/in, resolution reverts back to original value
instead of applied resolution.
Comment 4 Jani Välimaa 2019-05-21 06:17:06 CEST
Looks like the issue happens only with some icon themes. At least Adwaita and HighContrast icons aren't working, but with elementary Xfce icons the look is OK.

.xsession-errors had the following with Adwaita icons:

(xfce4-display-settings:2170): Gtk-CRITICAL **: 07:09:34.285: gtk_icon_info_load_symbolic: assertion 'icon_info != NULL' failed

(xfce4-display-settings:2170): GdkPixbuf-CRITICAL **: 07:09:34.285: gdk_pixbuf_get_n_channels: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(xfce4-display-settings:2170): GdkPixbuf-CRITICAL **: 07:09:34.285: gdk_pixbuf_get_height: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(xfce4-display-settings:2170): GdkPixbuf-CRITICAL **: 07:09:34.285: gdk_pixbuf_get_width: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'FooScrollArea': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkAlignment': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkFrame': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkBox': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkBox': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkNotebook': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkBox': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkBox': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'GtkBox': invalid value (typically too big) for the size of the input (surface, pattern, etc.)

(xfce4-display-settings:2170): Gtk-WARNING **: 07:09:34.285: drawing failure for widget 'XfceTitledDialog': invalid value (typically too big) for the size of the input (surface, pattern, etc.)
Comment 5 Jani Välimaa 2019-05-21 06:44:50 CEST
Created attachment 8558 
Fix deprecated icon causing the issues

Looks like the issue is caused by usage of deprecated icon. Attached patch replaces the icon and makes xfce4-display-settings to look OK at least with Adwaita icons.
Comment 6 bittwister 2019-05-21 08:12:26 CEST
I'll confirm patch fixes button problems. 

But clicking Apply still does not save resolution change. Next log out/in has old setting.
Comment 7 Olivier Fourdan editbugs 2019-05-21 09:55:45 CEST
(In reply to bittwister from comment #6)
> I'll confirm patch fixes button problems. 
> 
> But clicking Apply still does not save resolution change. Next log out/in
> has old setting.

That's a different issue, please file a different bug.
Comment 8 Jani Välimaa 2019-05-21 10:27:55 CEST
(In reply to Olivier Fourdan from comment #7)
> (In reply to bittwister from comment #6)
> > I'll confirm patch fixes button problems. 
> > 
> > But clicking Apply still does not save resolution change. Next log out/in
> > has old setting.
> 
> That's a different issue, please file a different bug.

Done, bug 15438.
Comment 9 Git Bot editbugs 2019-06-16 23:49:39 CEST
Jani Välimaa referenced this bugreport in commit 64a2b3240e432a39a09824814edf62dbb65d76f6

display: Replace deprecated icon (Bug #15416)

https://git.xfce.org/xfce/xfce4-settings/commit?id=64a2b3240e432a39a09824814edf62dbb65d76f6
Comment 10 Simon Steinbeiss editbugs 2019-06-16 23:50:07 CEST
Thanks for figuring this out and providing a patch!
Comment 11 Theo Linkspfeifer editbugs 2019-06-19 14:04:02 CEST
*** Bug 14887 has been marked as a duplicate of this bug. ***

Bug #15416

Reported by:
Jani Välimaa
Reported on: 2019-05-19
Last modified on: 2019-06-19
Duplicates (1):
  • 14887 Display settings broken in Git

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
4.13.6

Attachments

Hidden texts and buttons (29.45 KB, image/png)
2019-05-19 11:20 CEST , Jani Välimaa
no flags
Visible button (38.65 KB, image/png)
2019-05-19 11:22 CEST , Jani Välimaa
no flags
Fix deprecated icon causing the issues (984 bytes, patch)
2019-05-21 06:44 CEST , Jani Välimaa
no flags

Additional information