! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Display settings broken in Git
Status:
RESOLVED: DUPLICATE
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description Ali Akcaagac 2018-11-18 20:58:33 CET
Created attachment 8114 
Git messed up

Please have a view at the screenshot of the dialog. The entire thing looks messed up.

Buttons do show up once I hover over the areas where buttons are supposed to be (widgets generally). But they disappear as soon as the window loses focus.

Compiled last night. Git master.
Comment 1 Ali Akcaagac 2018-12-27 17:13:57 CET
Any progress with this issue ? Still present in Git...
Comment 2 Simon Steinbeiss editbugs 2019-01-07 22:50:13 CET
That looks very strange, I really can't reproduce that at all.
Can you try to either clean up your build environment (describing it would also be helpful)?
If the problem persists, I would be interested in a git bisect of which commit supposedly causes this breakage for you.
Comment 3 Ali Akcaagac 2019-01-07 23:20:22 CET
This is a clean build environment and the issue occoured after the recent changes. I do have an external monitor connected via VGA and have the display extended to the right.

Nothing else... All other Xfce related preferences window work perfectly. No issues. Only this one has the issues...

I am not really sure how to deal with this.

The base system I compile Git (master) with is Fedora 29 and the Xfce setup runs on that machine.
Comment 4 Ali Akcaagac 2019-01-07 23:24:24 CET
Created attachment 8229 
captured output of xfce4-display-settings when run through terminal

I was able to catch the output of xfce4-display-settings, when run through the terminal. Maybe this can help ?
Comment 5 Simon Steinbeiss editbugs 2019-01-08 00:42:52 CET
Right, the output isn't very helpful to be honest.
Could you run xfce4-display-settings through gdb and attach the backtrace?

Also, if you can, please build earlier versions of the dialog that still worked fine so that I know which of the "recent changes" you're referring too could be the culprit.
Comment 6 Ali Akcaagac 2019-01-08 01:23:54 CET
Yes I can checkout and re-build Git and then step back one commit after another, until I can track down working vs. non-working one.

But I can do this in a few days, because I have some important business related things going on in the next few days and I have to prepare myself for that event. Only wanted to let you know, in case you might be waiting for a quick response.
Comment 7 Ali Akcaagac 2019-01-12 13:45:58 CET
Found it!

This is the last version that worked!

-----------------------------------------
commit b619470f9904da23f3f752e8f2c4c338dd66c638 (HEAD -> master)
Author: Simon Steinbeiss <simon.steinbeiss@elfenbeinturm.at>
Date:   Sun Nov 11 23:36:43 2018 +0100

    Add interactive information about primary setting
    
    Currently we check if the Xfce panel, xfdesktop or xfce4-notifyd
    are configured to honour the "primary" setting.
-----------------------------------------
b619470f9904da23f3f752e8f2c4c338dd66c638
-----------------------------------------

So I assume that the issue may be related by the following commit

-----------------------------------------
commit 5916132c80c7623dfe589176dfd284791118a541 (HEAD -> master)
Author: Simon Steinbeiss <simon.steinbeiss@elfenbeinturm.at>
Date:   Mon Nov 12 00:33:20 2018 +0100

    display: Make primary indicator a star icon
-----------------------------------------
5916132c80c7623dfe589176dfd284791118a541
-----------------------------------------
Comment 8 Ali Akcaagac 2019-01-12 13:46:34 CET
Created attachment 8238 
screenshot illustrating the working display settings!
Comment 9 Ali Akcaagac 2019-01-12 13:50:10 CET
git reset --hard 5916132c80c7623dfe589176dfd284791118a541

and the issue came back. So 5916..... is the issue that causes the irritations here. May you have a peek please ?
Comment 10 Ali Akcaagac 2019-01-13 22:29:00 CET
When I go inside that dialog and turn off "primary" for the Notebook display, then the dialog operates properly.

There is a light bulb right to the primary icon, when I click on it I see:

Xfce Panel (not checkmark)
Desktop icons (checkmark)
Notifications (checkmark)

Though going inside the Panel settings (via configure next to light bulb popup), then I see that the panel has its output set as "primary".

So I believe that some "if/else" statements may cause irritation and thus decides to hide widgets in the display configure dialog.

But what else can I do here ?
Comment 11 Theo Linkspfeifer editbugs 2019-06-19 14:04:02 CEST

*** This bug has been marked as a duplicate of bug 15416 ***

Bug #14887

Reported by:
Ali Akcaagac
Reported on: 2018-11-18
Last modified on: 2019-06-19

People

Assignee:
Jérôme Guelfucci
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information