! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo-open fails with url encoded file paths
Status:
RESOLVED: FIXED

Comments

Description Mauro Santos 2015-06-25 17:53:27 CEST
The latest exo version (0.10.6) and the current git fail to open file paths with url encoding. In version 0.10.4 this worked without problems. This breaks some functionality for programs such as calibre which call xdg-open with url encoded paths, xdg-open on turn relies on exo-open which then fails.

Ex.:

exo-open 'file:///aulas/calibre/manuals/Dell%20Inc_/Setup%20Guide%20(85)/Setup%20Guide%20-%20Dell%20Inc_.pdf'

fails and shows a popup with:

/aulas/calibre/manuals/Dell%20Inc_/Setup%20Guide%20(85)/Setup%20Guide%20-%20Dell%20Inc_.pdf: No such file or directory

It makes no difference if single or double quotes are used. The pdf viewer (evince) is able to handle the file path without problems if opening the uri directly with evince (other viewer might not like it though).

I have done a git bisect and traced the commit that changes/breaks things to:
commit a2ac10b6b5c3378a46812a64f1afbbb22c38a8f9
Author: Sean Davis <smd.seandavis@gmail.com>
Date:   Thu May 21 21:15:47 2015 -0400

    Escape URIs for exo-open (bug 9912)

Reverting this commit on the current git master makes exo-open work again.
Comment 1 xuzhen 2015-07-18 18:28:43 CEST
Created attachment 6390 
fix bug 12017

The local file path should be escaped while being converted into a URI
Comment 2 Kevin Fenzi 2015-08-05 17:16:44 CEST
FYI, we hit this in fedora ( https://bugzilla.redhat.com/show_bug.cgi?id=1246383 ) and the patch in comment #1 seems to fix things up.
Comment 3 Sean Davis editbugs 2015-08-26 10:18:48 CEST
This may be fixed with along with this bug: https://bugzilla.xfce.org/show_bug.cgi?id=11942

Can you try with git-master and let me know how it goes?
Comment 4 Mauro Santos 2015-08-26 11:53:00 CEST
Current git master seem to fix the problem for me. Opening pdf files from within calibre works as expected.
Comment 5 Mauro Santos 2015-10-01 16:20:41 CEST
Marking as resolved, exo 0.10.7 works fine for me.

Bug #12017

Reported by:
Mauro Santos
Reported on: 2015-06-25
Last modified on: 2015-10-01

People

Assignee:
Nick Schermer
CC List:
4 users

Version

Version:
unspecified

Attachments

fix bug 12017 (3.53 KB, patch)
2015-07-18 18:28 CEST , xuzhen
no flags

Additional information