After commit http://git.xfce.org/xfce/exo/commit/?id=a2ac10b6b5c3378a46812a64f1afbbb22c38a8f9 exo-open escapes ? in magnet?:xt=urn:sha1:YNCKHTQCWBTRNJIV4WNAE52SJUQCZO5C with %3F. Magnet links handler (qBittorrent) handles it as incorrent magnet link.
Created attachment 6296 Non-ASCII path error Also can't open files with non-ASCII symbols in path.
I think this is related: -between exo 0.10.4 and exo 0.10.6 (which, basically, points to the commit that Arkadiy Illarionov mentioned), exo-open does not open anything with "%20" in it. This breaks Calibre when it tries to open the folder path to a book.
Again? (bug #9597). Does nobody do any testing? Is there no 'make check'? Please revert that commit, it's clearly a broken change that was done without any consideration to what exo-open actually does. First of all it's obvious that the escaping should be done ONLY in exo_open_find_scheme(); that's where we take a path and convert it to URL, it's totally stupid to assume that all the input of exo-open should be escaped. Secondly, why does 'exo-open file://$PWD/bla%23kdfj.txt' doesn't work? Clearly that change should be reverted until somebody does think this through and makes a patch that works correctly, and hopefully with some actual testing.
I wrote a patch that actually works. https://bugzilla.xfce.org/attachment.cgi?id=6394 The original commit is wrong, if you revert that and apply my patch everything works: * exo-open 'magnet:?xt=urn:btih:...' * exo-open 'file:///tmp/foo%23bar.txt' * exo-open '/tmp/foo#bar.txt'
Applied patch at http://git.xfce.org/xfce/exo/commit/?id=6faf134307a8f651c09931ae4f7017ce141f6320 Thanks!
Please do an exo release so this gets rolled out. Magnet links being broken is, IMO at least, significant.
IIUC, this fix appeared in the 0.10.7 release.