! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Plugin page crash (all disable) if you remove a shared directory.
Status:
RESOLVED: MOVED
Product:
Thunar-shares-plugin
Component:
General

Comments

Description Cyrille Pontvieux 2013-03-13 17:44:27 CET
If you share a repository using this plugin, then you delete this directory without removing the share, samba is ok with that, but not the plugin.
Why? Because the plugin rely on the equivalent of the command "net usershare info", and if a shared directory has been removed, you got this:

info_fn: file /var/lib/samba/usershares/lan is not a well formed usershare file.
info_fn: Error was Path is not a directory.

'lan' was my share for the deleted "/home/cpontvieux/LAN" folder path defined in it.
So in function "refresh_shares" in shares.c, net_usershare_run will fail and you the whole Gtk Page in thunar will be grayed out.

Remove the failed share and the plugin page is ok again.

Sorry I don't know samba share C functions and cannot provide a patch for it.

P.S. Tested using sha1 3a89ca67b27d717b13fed7851fce3244f31fc94e on Thunar 1.4
Comment 1 Git Bot editbugs 2020-05-20 21:18:55 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/thunar-plugins/thunar-shares-plugin/-/issues/9.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #9917

Reported by:
Cyrille Pontvieux
Reported on: 2013-03-13
Last modified on: 2020-05-20

People

Assignee:
Daniel Morales
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information