I'm using xubuntu 13.04 development release which has XFCE 4.12. Going to desktop settings and changing the icon size has no effect. The icon size doesn't change, and if you change it, close desktop settings, and go back to it you see the number has reset to 32.
*** Bug 9903 has been marked as a duplicate of this bug. ***
Not fixed in 4.10.2
I don't think it's regression in 4.10.1, nothing relevant has changed there. I can't exactly reproduce here: - If I click, on the arrows, it works - If I enter a new value manually: * and don't do anything else, I have to wait a bit before the icons get updated. If I close the dialog before the new value is taken into account, then this value is not "forwarded" to Xfconf. * and press enter, then the new value is taken into account immediately. The issue would be with the widget that takes a delay before forwarding new values on change without validation. Can anyone who reported the original issue confirm this, just to make sure we are speaking about the same thing?
(In reply to comment #3) > I don't think it's regression in 4.10.1, nothing relevant has changed there. > > I can't exactly reproduce here: > - If I click, on the arrows, it works Here it works *after* I validate with enter. > - If I enter a new value manually: > * and don't do anything else, I have to wait a bit before the icons get > updated. If I close the dialog before the new value is taken into account, > then this value is not "forwarded" to Xfconf. Even waiting a bit doesn't work. How much is “a bit” for you? > * and press enter, then the new value is taken into account immediately. Indeed. > > The issue would be with the widget that takes a delay before forwarding new > values on change without validation. > > Can anyone who reported the original issue confirm this, just to make sure > we are speaking about the same thing? Done.
Ok, I was not accurate enough. - Arrows work after a 2 second delay (can you confirm that?) - Changing text works with a tow second delay if you press enter or unfocus the entry. If the entry remains focused, the new value is not taken into account, that's how GtkSpinButton works. If we want a more predictable behaviour, we should maybe maybe start using a GtkAdjustment. Anyway, that's not a regression, it always worked (or did not...) like that as far as I know.
Created attachment 4952 Lower update delay value This patch makes the process smoother when the value is taken into account. The delay is used to avoid firing hundreds of events if you keep the buttons pressed.
(In reply to comment #5) > Ok, I was not accurate enough. > > - Arrows work after a 2 second delay (can you confirm that?) yes > - Changing text works with a tow second delay if you press enter or unfocus > the entry. 2 second here if I unfocus > If the entry remains focused, the new value is not taken into > account, that's how GtkSpinButton works. > > If we want a more predictable behaviour, we should maybe maybe start using a > GtkAdjustment. > > Anyway, that's not a regression, it always worked (or did not...) like that > as far as I know. I just tested on 4.8: - arrows work instantly - typing then unfocusing works instantly
FYI, this change was added in http://git.xfce.org/xfce/xfdesktop/commit/?id=d5e4dbea733153b74caba0e7a9c2bccc2ea5bf9c It was either from a forum post or direct e-mail about preventig the icons redrawing on every value change.
Pushed Jérôme's patch to master: http://git.xfce.org/xfce/xfdesktop/commit/?id=30ef6b2772c76899b3580e99ed754a8c5f18ca1c
Marking resolved.