! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
with /xfce4-power-manager/change-brightness-on-key-events=false, the brightne...
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Stefan Seyfried 2013-02-12 09:13:09 CET
Created attachment 4912 
fix brightness popup with  /xfce4-power-manager/change-brightness-on-key-events=false

In order to fix brightness change steps on my thinkpad x200s, I added the property
/xfce4-power-manager/change-brightness-on-key-events to xfconf:

xfconf-query -c xfce4-power-manager \
             -p /xfce4-power-manager/change-brightness-on-key-events \
             -n -t bool -s false

This works in general, but the popup's "volume bar" now always extends to the far right of the popup.
Inspecting the code, I found that the "level" variable in xfpm_backlight_button_pressed_cb() is not initialized in this case.

Attached patch fixes the issue.
Comment 1 Stefan Seyfried 2014-04-13 18:27:27 CEST
I rebased the patch against current master and added it to

https://github.com/b1-systems/for-upstream-xfce4-power-manager.git

branch "brightness-popup-fix" for easier merging :-)
Comment 2 Eric Koegel editbugs 2014-04-13 19:43:17 CEST
Thanks for this as well. Feel free to ping me if you write more patches :)
Pushed to master in:
http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=7f4fb9c021fb80d28d2ef7dcdbd3839a39d16f99

Bug #9850

Reported by:
Stefan Seyfried
Reported on: 2013-02-12
Last modified on: 2014-04-13

People

Assignee:
Ali Abdallah
CC List:
2 users

Version

Attachments

Additional information