! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfce4-notes-plugin -- current git fails to compile patch attached
Status:
RESOLVED: FIXED
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Derk te Bokkel 2013-01-02 17:39:45 CET
Sorry I'm a novice at using git and gtk but I'd like to learn but this has got me stumped:

Straight pull .. I've tried a few tarballs as well same issue 

I am aware this is a work in progress .. here is the error .. my builds are partially automated via gentoo ebuild mechanism but I do manual configures and makes as well (xdt-autogen etc.)

Making all in src
make[2]: Entering directory `/var/tmp/portage/xfce-extra/xfce4-notes-plugin-9999/work/xfce4-notes-plugin-9999/src'
  GEN      main-panel-plugin.c
main-panel-plugin.vala:39.3-39.38: error: Assignment: Cannot convert from `Gtk.Widget' to `Gtk.Button'
		button = Xfce.panel_create_button ();
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

can you point me in the right direction?
Comment 1 Derk te Bokkel 2013-01-03 16:53:56 CET
added a cast to  line 39 fixes issue  .. sorry I'm not versed in patch generation
is there a specific edit tool which makes it simple to do? i.e. preserves a backup copy .. I'm just using mousepad-0.3.0

fix for error in main-panel-plugin.vala line 39 last one shown here




public override void @construct () {
		Xfce.textdomain (Config.GETTEXT_PACKAGE, Config.PACKAGE_LOCALE_DIR);
		application = new Xnp.Application (save_location (true));

		button = (Gtk.Button) Xfce.panel_create_button ();
Comment 2 Derk te Bokkel 2013-01-03 17:06:49 CET
Created attachment 4831 
main-panel-plugin-cast.patch

I've submitted a patch hope it's correct format let me know

plugin is working at present
Comment 3 Derk te Bokkel 2013-01-03 20:03:06 CET
Created attachment 4832 
main-panel-plugin-cast.patch

replacement has directory src info in patch and this applies better
Comment 5 Mike Massonnet editbugs 2013-05-13 23:39:35 CEST
thanks for following and updating the status of the bug :)

Bug #9715

Reported by:
Derk te Bokkel
Reported on: 2013-01-02
Last modified on: 2013-05-13

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

main-panel-plugin-cast.patch (541 bytes, patch)
2013-01-03 17:06 CET , Derk te Bokkel
no flags
main-panel-plugin-cast.patch (549 bytes, patch)
2013-01-03 20:03 CET , Derk te Bokkel
no flags

Additional information