! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Duplicate volumes in thunar-device-monitor
Status:
RESOLVED: FIXED

Comments

Description Lionel Le Folgoc 2012-11-01 18:02:46 CET
Created attachment 4705 
Possible patch

Hi,

On some setups (always reproducible on Ubuntu 12.10, but I've read similar reports on Archlinux, and it seems to occur only with the latest gvfs 1.14.x), "volume-added" signals are sent for each volume the first time g_volume_monitor_get_volumes () is called.

This leads to duplicated volumes appearing in the sidepane (e.g. <http://pix.louiz.org/upload/original/1351761313.png>).

Maybe it's a bug in GIO/udev/GVfs, but regardless I think this can easily be avoided if thunar_device_monitor_volume_added () checks that the new volume doesn't exist already, either in the hidden list or the hash table.

Thanks.

(sorry, I couldn't test the possible patch here because I don't have this issue on Debian unstable, but I tested a similar patch against thunar 1.4.x for Xubuntu and it seemed to work fine)
Comment 1 Nick Schermer editbugs 2012-11-01 19:57:16 CET
Looks fine to me. Pushed fix in 70a4301.

Bug #9440

Reported by:
Lionel Le Folgoc
Reported on: 2012-11-01
Last modified on: 2012-11-23

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Possible patch (1.11 KB, patch)
2012-11-01 18:02 CET , Lionel Le Folgoc
no flags

Additional information