9390 – Crash in xfce_pointers_helper_init () if XGetExtensionVersion returns NoSuchExtension

Crash in xfce_pointers_helper_init () if XGetExtensionVersion returns NoSuchE...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-settings

Component:

Xfsettingsd

Comments

Description Lionel Le Folgoc 2012-10-19 22:23:40 CEST

Hi,

Bug #6302 has been fixed for xfce4-mouse-settings by http://git.xfce.org/xfce/xfce4-settings/commit/?id=01aa823b, but xfsettingsd is still vulnerable to the same crash: http://git.xfce.org/xfce/xfce4-settings/tree/xfsettingsd/pointers.c#n129

!version->present will crash if version == NoSuchExtension.

Comment 1 Lionel Le Folgoc 2012-10-28 16:36:42 CET

Created attachment 4699 
Proposed patch

Add the same check for NoSuchExtension

Comment 2 Nick Schermer editbugs

2012-10-28 17:10:57 CET

Pushed in 1d62ea7.

Bug #9390

Reported by:
Lionel Le Folgoc

Reported on: 2012-10-19
Last modified on: 2012-10-28

People

Assignee:
Nick Schermer

CC List:
2 users

Version

Version:
4.10.0

Target Milestone:
Xfce 4.6

Attachments

Proposed patch (445 bytes, patch)
2012-10-28 16:36 CET , Lionel Le Folgoc

no flags

Additional information