! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Xfdesktop uses fallback icons for removable devices attached before X...
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Brad Hermanson 2012-06-01 01:06:51 CEST
Created attachment 4482 
Patch that adds a signal handler for removable devices to update the icon when theme is changed

Starting Xfce with removable devices already attached causes xfdesktop to show the fallback icons instead of those for the current icon theme. It does fix itself when you move the cursor over the icon. I also noticed that when you change icon themes, the regular desktop icons change, but not those for the removable devices (until you hover over them). I looked through the source and figured out that it's because the "changed" signal for themes isn't caught for removable devices. My patch fixes this (I don't know if it's the best spot to put it though).

How to reproduce:

1. Plug in a usb device and start Xfce and notice the fallback icon for the device.

-or-

2. Plug in a usb device while Xfce is running and then change icon themes and notice that the removable device icon(s) don't change until you move the cursor over them.

Patch is attached.
Comment 1 Alexander Pantyuhin 2012-06-04 20:48:08 CEST
I confirm this problem.
Arch Linux x86_64 with Xfce 4.10
Comment 2 Fab 2012-06-05 09:39:14 CEST
Same thing here with Xfce 4.10 on Gentoo with *not mounted* internal partitions (which behaves like removable devices).
Comment 3 Thomas Lange 2012-11-06 19:15:22 CET
Created attachment 4715 
Screencast showing the problem

Same problem for me, appeared today probably after
executing "gtk-update-icon-cache".
A short screencast showing the issue is attached.

Refreshing the icon cache again or
removing ~/.cache/sessions did not solve it.
Comment 4 nucrap 2012-11-07 00:24:34 CET
*** Bug 9360 has been marked as a duplicate of this bug. ***

Bug #8977

Reported by:
Brad Hermanson
Reported on: 2012-06-01
Last modified on: 2013-01-26
Duplicates (1):
  • 9360 desktop icons of mounted volumes do not refresh their icon theme

People

Assignee:
Eric Koegel
CC List:
8 users

Version

Version:
4.10.0

Attachments

Additional information