! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[patch] gpg-agent isn't started/killed when user shell is not sh
Status:
RESOLVED: WONTFIX
Product:
Xfce4-session
Component:
General

Comments

Description Tijl Coosemans 2012-04-17 18:20:15 CEST
Created attachment 4335 
patch

Xfce runs gpg-agent (when available) from an xinitrc script. The commands gpg-agent returns depend on the user's shell. When you run gpg-agent from an sh script you must pass the --sh flag to make sure it returns sh commands. There are similar flags for ssh-agent and dbus-launch which the xinitrc script already uses.

I've attached a patch that fixes this. The patch also improves the kill command for gpg-agent by extracting the pid from the GPG_AGENT_INFO environment variable. The variable has 3 colon-separated fields. The second is the pid.
Comment 1 Nick Schermer editbugs 2012-04-19 21:01:39 CEST
Not an issues anymore in 4.10 since the shell is not used anymore.

Bug #8718

Reported by:
Tijl Coosemans
Reported on: 2012-04-17
Last modified on: 2012-04-19

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

patch (1.27 KB, patch)
2012-04-17 18:20 CEST , Tijl Coosemans
no flags

Additional information