! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Don't display gvfs-fuse-daemon
Status:
CLOSED: FIXED
Product:
Xfce4-mount-plugin
Component:
General

Comments

Description Mike Massonnet editbugs 2012-04-13 13:50:21 CEST
the plugin shouldn't display the gvfs-fuse-daemon "file-system", it should be blacklisted at all time.

currently it's possible to hide it by going into Properties>File systems>Exclude specific file systems and add gvfs-fuse-daemon.
Comment 1 Landry Breuil editbugs 2012-04-13 16:46:25 CEST
I dont have a system where gvfs-fuse-daemon works, so can you paste me the corresponding lines of etc/fstab + etc/mtab so that i see how to blacklist it ? you can have a look at devices.c:disks_refresh(). Maybe only removing the match on 'fuse' there and in disks_classify/disks_new should do the trick.
Comment 2 Mike Massonnet editbugs 2012-04-14 22:04:22 CEST
Created attachment 4320 
[PATCH] git-format-patch

Attached is a patch that blacklists gvfs-fuse-daemon.

PS: here is the line as displayed by mtab:
gvfs-fuse-daemon on /home/m8t/.gvfs type fuse.gvfs-fuse-daemon (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
Comment 3 Landry Breuil editbugs 2012-04-15 10:00:26 CEST
You mean that you don't see individual gvfs mounts, but only a single mount on .gvfs ? That's ugly.. if there were separate mounts that would have been interesting to show them, but if it's that way.. i suppose the df output for this mountpoint is useless too ? (ie doesn't display remote disk free by gvfs mount..)
Comment 5 Mike Massonnet editbugs 2012-04-15 11:52:14 CEST
(In reply to comment #3)
> You mean that you don't see individual gvfs mounts, but only a single mount
> on .gvfs ? That's ugly.. if there were separate mounts that would have been
> interesting to show them, but if it's that way.. i suppose the df output for
> this mountpoint is useless too ? (ie doesn't display remote disk free by
> gvfs mount..)

Individual Gvfs mounts can only be displayed with "gvfs-mount --list", they never appear with the command "mount" (neither does "df").

Marking this bug as CLOSED :)
Comment 6 Fabian Nowak editbugs 2012-04-16 10:51:17 CEST
CAn you please argue on why this should be blacklisted? IMHO the plugin should list nearly everything; very similar to mount and df.

So I am strongly in favor of removing this patch and leaving the user the choice to hide gvfs-fuse-daemon. I also had it blacklisted manually, that worked fine, and that's the purpose thereof.

Thanks for consideration.
Comment 7 Landry Breuil editbugs 2012-04-16 12:16:49 CEST
I'll let mike argue (cause i dont have an opinion, not having gvfs-fuse-daemon), but i think the rationale is hiding useless mountpoints. In that case, it's of no interest to show it, since it doesnt give information, nor manual mounting/umounting does what the user want, ie mount/unmount gvfs mounts, which should be adressed by directly talking to gvfs and would be a completely different issue ?. The plugin already 'whitelists' based on fs type/device path after all....
Comment 8 Mike Massonnet editbugs 2012-04-16 20:27:25 CEST
(In reply to comment #6)
> CAn you please argue on why this should be blacklisted? IMHO the plugin
> should list nearly everything; very similar to mount and df.
> 
> So I am strongly in favor of removing this patch and leaving the user the
> choice to hide gvfs-fuse-daemon. I also had it blacklisted manually, that
> worked fine, and that's the purpose thereof.
> 
> Thanks for consideration.

As written, individual Gvfs mounts aren't displayed by the plugin, and the mounpoint "gvfs-fuse-daemon" doesn't make sense to be kept around.

You can run the command "fusermount -u $HOME/.gvfs" to unmount the mount point, but that is clearly not wished either. No one should mess around with the process "gvfs-fuse-daemon". The "gvfs-fuse-daemon" process allows you to browse mounted file systems inside "~/.gvfs". That's it. For being able to unmount mount points created with "gvfs-mount", the plugin should support "gvfs" anyway.

Now I had like to stop arguing there. If you think there is a valid point to have an unuseful entry in the plugin, just give an argument in that direction, and not the other way around.

Bug #8684

Reported by:
Mike Massonnet
Reported on: 2012-04-13
Last modified on: 2012-04-16

People

Assignee:
Landry Breuil
CC List:
2 users

Version

Version:
unspecified

Attachments

[PATCH] git-format-patch (929 bytes, patch)
2012-04-14 22:04 CEST , Mike Massonnet
no flags

Additional information