! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Support for colord in xfsettingsd
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Xfce4-settings
Component:
Xfsettingsd

Comments

Description Kurt Roeckx 2012-03-10 22:39:54 CET
Hi,

I would like to use colord in xfce, but I understand that the session should set up things for that.

See:
https://bugs.freedesktop.org/show_bug.cgi?id=47189
and:
http://www.freedesktop.org/software/colord/faq.html#gcm

Kurt
Comment 1 unhammer+dill 2013-05-14 09:16:23 CEST
Does this mean it's currently not possible to run colord at all in XFCE, or are there workarounds / "manual" ways to call CreateProfile etc.?
Comment 2 Simon Steinbeiss editbugs 2019-02-09 00:21:33 CET
I have started to work on this. Currently printing, scanning and cameras work with plain Xfce and colord, however you still need xiccd for display color profiles (haven't integrated the daemon side for display color profiles yet).
Comment 3 Simon Steinbeiss editbugs 2019-02-24 21:25:52 CET
Just for completeness sake, the status quo is summarized here:
https://simon.shimmerproject.org/2019/02/19/color-profile-support-for-xfce/

Note that the current progress only concerns the frontend to interact with colord, not the backend (yet), so you still need xiccd.
Comment 4 onkelho 2019-03-01 16:01:09 CET
error with actual from git builded packages:

Making all in color-settings
make[3]: Entering directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
exo-csource --static --strip-comments --strip-content --name=color_dialog_ui color-dialog.glade >color-dialog_ui.h
make[3]: Leaving directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
make  all-am
make[4]: Entering directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
  ITMRG  xfce4-color-settings.desktop
make[4]: Leaving directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
make[4]: Entering directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
  CC       xfce4_color_settings-color-profile.o
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/glib/gi18n.h:21,
                 from color-profile.c:24:
color-profile.c: In function 'color_profile_changed_cb':
color-profile.c:286:13: error: unknown type name 'CdProfile_autoptr'
   g_autoptr(CdProfile) profile = NULL;
             ^
/usr/include/glib-2.0/glib/gmacros.h:504:43: note: in definition of macro '_GLIB_AUTOPTR_TYPENAME'
 #define _GLIB_AUTOPTR_TYPENAME(TypeName)  TypeName##_autoptr
                                           ^~~~~~~~
color-profile.c:286:3: note: in expansion of macro 'g_autoptr'
   g_autoptr(CdProfile) profile = NULL;
   ^~~~~~~~~
color-profile.c:286:3: error: cleanup argument not a function
color-profile.c:286:34: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
   g_autoptr(CdProfile) profile = NULL;
                                  ^~~~
color-profile.c:289:11: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
   profile = cd_device_get_default_profile (device);
           ^
color-profile.c:290:15: warning: comparison between pointer and integer
   if (profile != NULL)
               ^~
color-profile.c:291:72: warning: passing argument 1 of 'cd_profile_get_object_path' makes pointer from integer without a cast [-Wint-conversion]
     color_profile->is_default = g_strcmp0 (cd_profile_get_object_path (profile),
                                                                        ^~~~~~~
In file included from /usr/include/colord-1/colord/cd-device.h:33:0,
                 from /usr/include/colord-1/colord/cd-client.h:32,
                 from /usr/include/colord-1/colord.h:42,
                 from color-profile.h:25,
                 from color-profile.c:27:
/usr/include/colord-1/colord/cd-profile.h:109:14: note: expected 'CdProfile * {aka struct <anonymous> *}' but argument is of type 'int'
 const gchar *cd_profile_get_object_path  (CdProfile *profile);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:671: xfce4_color_settings-color-profile.o] Error 1
make[4]: Leaving directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
make[4]: *** Waiting for unfinished jobs....
make[4]: Entering directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
  CC       xfce4_color_settings-main.o
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/colord-1/colord/cd-buffer.h:29,
                 from /usr/include/colord-1/colord.h:41,
                 from main.c:28:
main.c: In function 'color_settings_button_assign_ok_cb':
main.c:424:15: error: unknown type name 'CdProfile_autoptr'
     g_autoptr(CdProfile) profile = NULL;
               ^
/usr/include/glib-2.0/glib/gmacros.h:504:43: note: in definition of macro '_GLIB_AUTOPTR_TYPENAME'
 #define _GLIB_AUTOPTR_TYPENAME(TypeName)  TypeName##_autoptr
                                           ^~~~~~~~
main.c:424:5: note: in expansion of macro 'g_autoptr'
     g_autoptr(CdProfile) profile = NULL;
     ^~~~~~~~~
main.c:424:5: error: cleanup argument not a function
main.c:424:36: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
     g_autoptr(CdProfile) profile = NULL;
                                    ^~~~
main.c:440:17: warning: comparison between pointer and integer
     if (profile == NULL) {
                 ^~
main.c:461:39: warning: passing argument 3 of 'cd_device_add_profile_sync' makes pointer from integer without a cast [-Wint-conversion]
                                       profile,
                                       ^~~~~~~
In file included from /usr/include/colord-1/colord.h:47:0,
                 from main.c:28:
/usr/include/colord-1/colord/cd-device-sync.h:46:11: note: expected 'CdProfile * {aka struct <anonymous> *}' but argument is of type 'int'
 gboolean  cd_device_add_profile_sync  (CdDevice *device,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~
main.c:471:37: warning: passing argument 2 of 'cd_device_make_profile_default' makes pointer from integer without a cast [-Wint-conversion]
                                     profile,
                                     ^~~~~~~
In file included from /usr/include/colord-1/colord/cd-client.h:32:0,
                 from /usr/include/colord-1/colord.h:42,
                 from main.c:28:
/usr/include/colord-1/colord/cd-device.h:113:8: note: expected 'CdProfile * {aka struct <anonymous> *}' but argument is of type 'int'
 void   cd_device_make_profile_default  (CdDevice *device,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/colord-1/colord/cd-buffer.h:29,
                 from /usr/include/colord-1/colord.h:41,
                 from main.c:28:
main.c: In function 'color_settings_profile_import_cb':
main.c:527:15: error: unknown type name 'CdProfile_autoptr'
     g_autoptr(CdProfile) profile = NULL;
               ^
/usr/include/glib-2.0/glib/gmacros.h:504:43: note: in definition of macro '_GLIB_AUTOPTR_TYPENAME'
 #define _GLIB_AUTOPTR_TYPENAME(TypeName)  TypeName##_autoptr
                                           ^~~~~~~~
main.c:527:5: note: in expansion of macro 'g_autoptr'
     g_autoptr(CdProfile) profile = NULL;
     ^~~~~~~~~
main.c:527:5: error: cleanup argument not a function
main.c:527:36: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
     g_autoptr(CdProfile) profile = NULL;
                                    ^~~~
main.c:538:13: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
     profile = cd_client_import_profile_sync (settings->client,
             ^
main.c:542:17: warning: comparison between pointer and integer
     if (profile == NULL) {
                 ^~
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/colord-1/colord/cd-buffer.h:29,
                 from /usr/include/colord-1/colord.h:41,
                 from main.c:28:
main.c: In function 'color_settings_assign_profile_info_cb':
main.c:650:15: error: unknown type name 'CdProfile_autoptr'
     g_autoptr(CdProfile) profile = NULL;
               ^
/usr/include/glib-2.0/glib/gmacros.h:504:43: note: in definition of macro '_GLIB_AUTOPTR_TYPENAME'
 #define _GLIB_AUTOPTR_TYPENAME(TypeName)  TypeName##_autoptr
                                           ^~~~~~~~
main.c:650:5: note: in expansion of macro 'g_autoptr'
     g_autoptr(CdProfile) profile = NULL;
     ^~~~~~~~~
main.c:650:5: error: cleanup argument not a function
main.c:650:36: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
     g_autoptr(CdProfile) profile = NULL;
                                    ^~~~
main.c:660:17: warning: comparison between pointer and integer
     if (profile == NULL) {
                 ^~
main.c:664:39: warning: passing argument 1 of 'color_settings_profile_info_view' makes pointer from integer without a cast [-Wint-conversion]
     color_settings_profile_info_view (profile, settings);
                                       ^~~~~~~
main.c:615:1: note: expected 'CdProfile * {aka struct <anonymous> *}' but argument is of type 'int'
 color_settings_profile_info_view (CdProfile *profile, ColorSettings *settings)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:643: xfce4_color_settings-main.o] Error 1
make[4]: Leaving directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
make[4]: Entering directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
  CC       xfce4_color_settings-color-device.o
make[4]: Leaving directory '/repm/src/rpm/BUILD/xfce4-settings-4.14.0/dialogs/color-settings'
make[3]: *** [Makefile:518: all] Error 2
make[2]: *** [Makefile:496: all-recursive] Error 1
make[1]: *** [Makefile:547: all-recursive] Error 1
make: *** [Makefile:479: all] Error 2
error: Bad exit status from /home/quait/src/tmp/rpm-tmp.zoag3q (%build)

hope that will help
Comment 5 onkelho 2019-03-01 20:32:51 CET
it's solved by upgrade to a actual version of colord
-> hint:  colord is build without systemd by use the -Dsystemd=false option
it's good for folks would works without systemd,
so you knowing xfce4-settings not need systemd for colord-settings
Excuse my first posting
Thank you all for your hard work!
Comment 6 Git Bot editbugs 2020-05-28 22:53:34 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/7.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #8559

Reported by:
Kurt Roeckx
Reported on: 2012-03-10
Last modified on: 2020-05-28

People

Assignee:
Simon Steinbeiss
CC List:
11 users

Version

Version:
unspecified

Attachments

Additional information