Comment 1 Mike Massonnet 2012-02-15 06:45:18 CET

Don't install in /lib unless the plugin is compiled as a module. Genmon is compiled as an executable binary, therefore keep it in /libexec.

Odd. The exact same thing just happened for systemload (bug 7077)

Okay, so how about we make it compile as a module :)

Created attachment 4201 
Make it compile as a module

Created attachment 4203 
Removes the desktop.in.in indirection

We can remove the desktop.in.in as indirection thanks to this.

Created attachment 4204 
Gitignore for good measure

Created attachment 4208 
Bump the XDT requirement to 4.9.1

One last patch that bumps the XDT requirement to 4.9.1 (for libtool).

Comment 8 John Lindgren 2012-02-17 17:52:13 CET

(In reply to comment #0)
> Patch for the bug.

Patch for what bug?

Comment 9 Mike Massonnet 2012-02-17 19:48:15 CET

For this bug, check the bug subject.

Comment 10 John Lindgren 2012-02-17 21:05:05 CET

(In reply to comment #9)
> For this bug, check the bug subject.
Thank you but I have read the bug subject already and it does not say why there is a problem with the way things are done now, it only requests that they be done differently for some unknown reason.  Maybe I am missing something obvious?

libexec and REGISTER_EXTERNAL are deprecated.

Comment 12 Mike Massonnet 2012-02-25 11:48:36 CET

(In reply to comment #10)
> (In reply to comment #9)
> > For this bug, check the bug subject.
> Thank you but I have read the bug subject already and it does not say why there
> is a problem with the way things are done now, it only requests that they be
> done differently for some unknown reason.  Maybe I am missing something
> obvious?
Actually, there is nothing wrong the way it works currently:
- the location where the plugin files are installed
- the fact that it is compiled as an executable

Starting xfce panel 4.9, the location where the plugin is currently installed has been marked as deprecated but is still supported. What the newer version now suggests is to install the plugin under a new path for plugins compiled as a module.

NB: plugins compiled as executables have to be installed under libexec (packagers can tweak that under lib/package-name/)

The patch is hereby provided for these changes.

Comment 13 John Lindgren 2012-05-10 01:22:57 CEST

I've applied the two patches to compile as a module and remove the genmon.desktop.in.in indirection.  Thank you.
http://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/?id=0c4c582e87f1f0b4b36782b3d4dc021bffce93df
http://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/?id=e3b80386c076941bb43eac514143ab4a9d094b5b

The XDT requirement patch is necessary for autogen.sh to work straight from git (older versions don't handle libtool properly; you have to run libtoolize or autoreconf -i manually).  It doesn't affect releases, since releases do not require XDT.

Also, you can apply patches generated by git format-patch more easily using git am.

Comment 16 John Lindgren 2012-05-12 00:45:33 CEST

Applied.
http://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/?id=b6a9f9f07717c6aa8e9d0b271b053662f0005328