! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfmedia does not install properly if make != gmake
Status:
RESOLVED: FIXED
Product:
Xfmedia
Component:
general

Comments

Description Benedikt Meurer editbugs 2005-03-15 16:15:06 CET
The latest version of Xfmedia does not install properly if make is not GNU make.
The error message is:

test -z "/opt/local/share/applications" || /bin/bash ./mkinstalldirs
"/opt/local/share/applications"
 /usr/bin/install -c -m 644 'xfmedia.desktop'
'/opt/local/share/applications/xfmedia.desktop'
(cd doc && make install)
make: don't know how to make w. Stop
gmake[2]: *** [install-data-local] Error 2
gmake[2]: Leaving directory `/usr/home/bmeurer/Projects/xfmedia'
gmake[1]: *** [install-am] Error 2
gmake[1]: Leaving directory `/usr/home/bmeurer/Projects/xfmedia'
gmake: *** [install-recursive] Error 1

Why not use SUBDIRS instead? 

If there's a reason for this explicit make calls, use $(MAKE) instead and add
@SET_MAKE@ to the Makefile.am and AC_PROG_MAKE_SET() to configure.ac.

On a side note: Your docbook check uses hardcoded paths below /usr, which will
most certainly fail for all unix/linux systems except for a few linux
distributions, even if docbook is installed and setup properly.
Comment 1 Brian J. Tarricone (not reading bugmail) 2005-03-15 16:40:59 CET
(In reply to comment #0)
> The latest version of Xfmedia does not install properly if make is not GNU make.
> 
> Why not use SUBDIRS instead? 

There *was* a reason, though I don't recall what it was atm.

> If there's a reason for this explicit make calls, use $(MAKE) instead and add
> @SET_MAKE@ to the Makefile.am and AC_PROG_MAKE_SET() to configure.ac.

Yeah, forgot.  Fixed, though I should try and figure out why I'm doing it this
way...

> On a side note: Your docbook check uses hardcoded paths below /usr, which will
> most certainly fail for all unix/linux systems except for a few linux
> distributions, even if docbook is installed and setup properly.

Not terribly relevant.  The only place it *has* to work is on my machine, as I
distribute the generated files in the tarball, and commit them to CVS as well. 
Besides, I was unable to find a "standard" way of detecting whether or not
docbook is installed.  Admittedly, I didn't look all that hard.
Comment 2 Brian J. Tarricone (not reading bugmail) 2005-03-31 06:02:30 CEST
Ah, I remember now.  It's that way because I want the documentation to be
installed, but only to be built if I tell it to.  Yeah, there's a better way to
do it (flag to configure, I guess), but this way makes it easier for me to be
lazy.  Anyway, the build problem where make != gmake should be fixed.

Bug #836

Reported by:
Benedikt Meurer
Reported on: 2005-03-15
Last modified on: 2005-03-31

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Version:
0.7.0cvs

Attachments

Additional information