! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Need to investigate GTK+ version dependency for ristretto 0.3.2
Status:
RESOLVED: FIXED
Product:
Ristretto
Component:
Application

Comments

Description Peter Tribble 2012-01-14 18:42:59 CET
ristretto 0.3.2 calls some GTK+ functions that aren't present in GTK+ 2.20.1. My build (on Solaris, but I don't think the OS is relevant) fails with:

Undefined			first referenced
 symbol  			    in file
gtk_combo_box_text_insert_text      ristretto-preferences_dialog.o
gtk_message_dialog_get_message_area ristretto-thumbnailer.o
GTK_COMBO_BOX_TEXT                  ristretto-preferences_dialog.o
gtk_combo_box_text_new              ristretto-preferences_dialog.o

These appear to be present in GTK+ 2.24.7, as I can build ristretto 0.3.2 just fine against that version of GTK+.

Currently the defined minimum version of GTK+ for Xfce 4.8 is 2.14 and for 4.10 was supposed to be 2.20 (from the roadmap on the wiki). It would therefore be preferable, I guess, to fix the code to work with GTK+ 2.20. If not possible, then configure should check for the correct version.
Comment 1 Stephan Arts editbugs 2012-01-14 18:55:45 CET
Oh, damn.

I've fixed it in master.
Comment 2 Stephan Arts editbugs 2012-01-14 18:56:07 CET
Thank you for reporting it ;-)
Comment 3 Stephan Arts editbugs 2012-01-14 18:57:18 CET
You can cherry-pick this commit: 1afe420b865ef8f86f26090462e9217fe789089a

To fix it yourself :)
Comment 4 Guido Berhoerster 2012-01-28 11:45:44 CET
This is not fixed, GtkComboBoxText symbols from GTK 2.24 are still being used, build currently fails due to:
[...]
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1968: undefined reference to `gtk_combo_box_text_new'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1975: undefined reference to `GTK_COMBO_BOX_TEXT'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1975: undefined reference to `gtk_combo_box_text_insert_text'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1979: undefined reference to `GTK_COMBO_BOX_TEXT'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1979: undefined reference to `gtk_combo_box_text_insert_text'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1983: undefined reference to `GTK_COMBO_BOX_TEXT'
/usr/src/packages/BUILD/ristretto-0.3.4/src/main_window.c:1983: undefined reference to `gtk_combo_box_text_insert_text'
[...]

There may be more cases.
Comment 5 Stephan Arts editbugs 2012-01-29 09:21:01 CET
Hmm.... I've changed that.

Can you test if it compiles with this patch?

http://git.xfce.org/apps/ristretto/commit/?h=ristretto-0.3&id=a4005e226864429f027aad86d1a2d1a74c8d28d0
Comment 6 Guido Berhoerster 2012-01-29 11:38:45 CET
Yes, that was all. Thanks.
Comment 7 Stephan Arts editbugs 2012-01-29 16:16:22 CET
Ok, finally closing.

Bug #8343

Reported by:
Peter Tribble
Reported on: 2012-01-14
Last modified on: 2012-01-29

People

Assignee:
Stephan Arts
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information