! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix compilation against GTK+ 2.20
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfce4-appfinder
Component:
General

Comments

Description Mike Massonnet editbugs 2011-10-16 18:41:46 CEST 
Created attachment 3899 
0001-Fix-compilation-against-GTK-2.20.patch

Attached is a patch that fixes compilation against GTK+ 2.20.

Currently the code uses GDK_KEY_Up/Down while this was introduced in GTK+ 2.22.
Comment 1 Nick Schermer editbugs 2011-10-30 12:47:44 CET 
4.8 does not use GDK_KEY_*, neither does master.
Comment 2 Mike Massonnet editbugs 2011-10-30 18:03:52 CET 
The appfinder currently has two lines of code that uses GDK_KEY_*:

  $  grep GDK_KEY *

appfinder-window.c:591:  if (event->keyval == GDK_KEY_Up || event->keyval == GDK_KEY_Down)
appfinder-window.c:593:      expand = (event->keyval == GDK_KEY_Down);
Comment 3 Nick Schermer editbugs 2011-10-30 18:21:54 CET 
My bad, sorry. Search in 4.8 and assumed in master.

Bug #8044

Reported by:
Mike Massonnet
Reported on: 2011-10-16
Last modified on: 2011-10-30

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
Unspecified
Target Milestone:
Xfce 4.6

Attachments

0001-Fix-compilation-against-GTK-2.20.patch (688 bytes, patch)
2011-10-16 18:41 CEST , Mike Massonnet 		no flags

Additional information