From the downstream report: open a jpeg in ristretto (e.g. https://bugzilla.novell.com/attachment.cgi?id=456324) press clockwise or counterclockwise rotation icons several times. ristretto crashes backtrace: #0 gdk_pixbuf_rotate_simple (src=0x0, angle=GDK_PIXBUF_ROTATE_COUNTERCLOCKWISE) at gdk-pixbuf-scale.c:414 414 gdk-pixbuf-scale.c: No such file or directory. in gdk-pixbuf-scale.c (gdb) where #0 gdk_pixbuf_rotate_simple (src=0x0, angle=GDK_PIXBUF_ROTATE_COUNTERCLOCKWISE) at gdk-pixbuf-scale.c:414 #1 0x08053978 in cb_rstto_image_viewer_queued_repaint (viewer= 0x8137138 [RsttoImageViewer]) at image_viewer.c:1758 #2 0xb6fa9c80 in g_idle_dispatch (source=0x831efc0, callback= 0x80529e0 <cb_rstto_image_viewer_queued_repaint>, user_data=0x8137138) at gmain.c:4801 #3 0xb6fadddf in g_main_dispatch (context=0x809c0f8) at gmain.c:2441 #4 g_main_context_dispatch (context=0x809c0f8) at gmain.c:3011 #5 0xb6fae510 in g_main_context_iterate (context=0x809c0f8, block=-1225011456, dispatch=1, self=<optimized out>) at gmain.c:3089 #6 0xb6faeb1b in g_main_loop_run (loop=0x8207ce0) at gmain.c:3297 #7 0xb752deff in IA__gtk_main () at gtkmain.c:1256 #8 0x08050eda in main (argc=5, argv=0xbfb240b4) at main.c:137 (gdb) This happens with ristretto 0.1.1.
Git master is ported to cairo, so this code no longer exists. Closing this ticket :-)
It would be nice if you at least supported your latest release because that is what openSUSE 12.1 users will face for the next 8 months :(
Created attachment 3908 Fix a possible segfault when tmp_pixbuf could not be created. I have a quick patch here, it prevents the segfault. I'll have another look into why this ever breaks. - See if I can find a cleaner solution.
Created attachment 3909 Patch, preventing segfault and writing debug statement when the error-situation occurs. This patch fixes the segfault, applies some rounding corrections and prints a warning when the problem described in the upstream ticket occurs.
If you can confirm that this patch solves the issue (i.e. I can not reproduce) Then I'll release a 0.1.2 with this fix applied :)
(In reply to comment #5) > If you can confirm that this patch solves the issue (i.e. I can not reproduce) > > Then I'll release a 0.1.2 with this fix applied :) Thanks for the quick fix! I've packaged the patch and will get back to you as soon as I have feedback from the original reporter. We're in release freeze so I will just include this patch into the openSUSE package, since this also affects 0.2.0 I'd suggest a 0.2.1 release which might be useful to other distros/users.
You might want to explain to the reporter that the reported crash is not expected to occur, if the conditions that led to the crash earlier still apply the application will log this to the CLI with a warning.
OK. Interestingly I cannot reproduce the crash myself even with the image provided by the reporter.
Can this ticket be closed?
(In reply to comment #9) > Can this ticket be closed? I haven't gotten a response from the reporter after updating the package to version 0.2.2 and cannot reproduce myself. Feel free to close this, I can reopen in case this still occurs.
Closing ticket.