! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Please support image-path hint for org.freedesktop.Notifications interface
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-notifyd
Component:
general

Comments

Description Bartosz Brachaczek 2011-07-27 17:34:10 CEST
The current version of Desktop Notifications Specification describes image-path hint for a notification that has a similar meaning to image-data (already implemented in Xfce4-notifyd as image_data). It would be very nice if Xfce4-notifyd could start supporting it the more that it already supports image_data. This feature is already supported by KDE Plasma notifications, notify-osd, and notification-daemon (I have some problems with the latter, though).
Comment 1 Simon Steinbeiss editbugs 2016-09-18 22:20:59 CEST
This sounds easy enough. Is there any application I could test this behavior with?
Comment 2 Simon Steinbeiss editbugs 2016-09-18 22:38:00 CEST
Created attachment 6856 
Adding support for image-path

As I'm not sure yet how to test this (and the tests for icons haven't been written yet) I'm attaching a patch which should implement the image-path hint.

Please test and let me know whether it works!
Comment 3 Simon Steinbeiss editbugs 2016-09-18 22:56:33 CEST
Oh, and please note that the priority is not handled according to https://developer.gnome.org/notification-spec/#id2776582 yet, currently it's still app_icon > image-data > image-path.
Comment 4 Bartosz Brachaczek 2016-09-18 23:11:28 CEST
Thanks for looking into it, but unfortunately I haven't since been writing desktop applications much and I don't remember any details now. Too bad I didn't include a repro app in the original report.
Comment 5 Simon Steinbeiss editbugs 2016-09-30 22:26:21 CEST
No worries, I quickly wrote a test and it works. I guess the only thing left to do is adjust the priorities of the icons to follow the spec.

Pushed to master:
https://git.xfce.org/apps/xfce4-notifyd/commit/?id=806524033f39bcb8444a5aa7b2a6f9ea323317ed

Bug #7846

Reported by:
Bartosz Brachaczek
Reported on: 2011-07-27
Last modified on: 2016-09-30

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Version:
unspecified

Attachments

Adding support for image-path (1.78 KB, patch)
2016-09-18 22:38 CEST , Simon Steinbeiss
no flags

Additional information