! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop-settings crashes when on read errors for desktop images
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfdesktop
Component:
General

Comments

Description Ambroz Bizjak 2011-02-18 11:13:32 CET 
Created attachment 3480 
Patch

xfdesktop_image_file_is_valid in xfdesktop/common/xfdesktop-common.c crashes when read() fails and returns -1, because the result is converted to an unsigned integer.

To reproduce:
# mkdir /usr/share/xfce4/backdrops/dummy
$ xfdesktop-settings
Segmentation fault
Comment 1 Jérôme Guelfucci editbugs 2011-03-29 21:15:32 CEST 
I can't reproduce the crash but the patch is still valid, I just pushed it to the master and xfce-4.8 branches. Thanks for your contribution!

Bug #7301

Reported by:
Ambroz Bizjak
Reported on: 2011-02-18
Last modified on: 2011-03-29

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
2 users

Version

Version:
Unspecified
Target Milestone:
Xfce 4.6

Attachments

Patch (388 bytes, patch)
2011-02-18 11:13 CET , Ambroz Bizjak 		no flags

Additional information