! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar embeds tdb library
Status:
RESOLVED: INVALID

Comments

Description Yves-Alexis Perez editbugs 2011-02-14 17:03:46 CET
Hey,

it seems that Thunar embeds the tdb library. Can't it use the system tdb library instead of shipping its own?

It seems that it was imported by Benedikt in 2005 and was only updated to fix compiler warnings.
Comment 1 Yves-Alexis Perez editbugs 2011-02-14 20:53:10 CET
I have a tentative patch, but trying to look at the results, I saw:

-rw------- 1 corsac corsac 8,0K  9 janv.  2010 .cache/Thunar/metafile.tdb

so is the tdb cache really used at all?
Comment 2 Yves-Alexis Perez editbugs 2011-02-14 22:44:02 CET
Created attachment 3475 
use system tdb library
Comment 3 Yves-Alexis Perez editbugs 2011-02-14 22:46:52 CET
Grmbl, lost my previous comment by attaching the patch.

So here's a tentative patch (against master but it applies fine to 1.2.1) to remove embedded tdb and use system one. Emblems are displayed correctly so I guess the cache works fine. 

I didn't set any required version but it might be best to set it to the version Benny used at that time.

I've casted the gchar * (from g_file_get_uri) to unsigned char* to fix warnings from the compiler.
Comment 4 Nick Schermer editbugs 2011-02-15 09:23:42 CET
The real solution would be using the GVFS backend for storing emblems and if we keep tdb, it should link optionally to the system version.
Comment 5 Yves-Alexis Perez editbugs 2011-02-16 11:42:55 CET
Yeah it might not make sense to keep tdb at all. By optional you mean optional support at all or optional system support (and fall back to internal copy)?
Comment 6 Nick Schermer editbugs 2011-02-16 16:43:13 CET
Yes, IIRC tdb was previously shipped inside samba, so better to fallback if not found (or with --disable-tdb).
Comment 7 Yves-Alexis Perez editbugs 2011-02-17 08:27:42 CET
It seems that most distributions ship tdb separately from samba: 

http://dde.debian.net/dde/q/distromatch/match/debian/libtdb1
http://dde.debian.net/dde/q/distromatch/match/debian/libtdb-dev
Comment 8 Nick Schermer editbugs 2012-10-12 12:45:16 CEST
Dropped the lib and rely on gvfs-metadata instead in master. We only use it for emblems atm.

Bug #7286

Reported by:
Yves-Alexis Perez
Reported on: 2011-02-14
Last modified on: 2012-10-12

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
unspecified

Attachments

use system tdb library (112.01 KB, patch)
2011-02-14 22:44 CET , Yves-Alexis Perez
no flags

Additional information