! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
orage-4.8.0 (and git) fails to compile with libnotify-0.7 API
Status:
CLOSED: FIXED

Comments

Description Samuli Suominen 2011-01-29 14:52:00 CET
[ .. ]

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..    -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -I/usr/include/libdrm   -DPACKAGE_DATA_DIR=\""/usr/share"\" -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\"  -I/usr/include/   -DDBUS_API_SUBJECT_TO_CHANGE -pthread -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -march=core2 -msse4.1 -O2 -pipe -I/usr/include/libical -c -o orage-tray_icon.o `test -f 'tray_icon.c' || echo './'`tray_icon.c
reminder.c: In function ‘create_notify_reminder’:
reminder.c:560:5: error: too many arguments to function ‘notify_notification_new’
/usr/include/libnotify/notification.h:114:21: note: declared here

[ .. ]

You can find solution from Xfce Core packages which are compatible with it, or from commits like this:

http://git.gnome.org/browse/network-manager-applet/commit/?id=68459b6b864ad45a842bfd1bdc80f126829ef596
Comment 1 Samuli Suominen 2011-01-29 15:00:15 CET
Created attachment 3439 
Fix the code for libnotify-0.7

The code could look like this, just needs the configure bits added
Comment 2 juha editbugs 2011-01-29 18:59:23 CET
I wonder why they took away those features. But can't help. Need to change the code.
Comment 3 Samuli Suominen 2011-01-29 19:03:26 CET
Thunar might have better code, check this:

http://git.xfce.org/xfce/thunar/tree/thunar/thunar-notify.c

Like:

#ifdef NOTIFY_CHECK_VERSION
#if NOTIFY_CHECK_VERSION (0, 7, 0)
Comment 4 Samuli Suominen 2011-01-29 19:04:24 CET
So that way you could avoid messing with configure.{ac,in} altogether. :)
Comment 5 juha editbugs 2011-01-30 08:26:27 CET
Thanks! 
I do not have a system with libnotify 0.7, but I will fix Orage like Thunar using NOTIFY_CHECK_VERSION hoping it works.
Comment 6 juha editbugs 2011-01-30 08:56:14 CET
Fixed in Orage 4.8.0.5 in git now.

I can't test this though as I do not have access to libnotify 0.7.0, so it would be nice if somebody could
confirm that compile now works.
Comment 7 Samuli Suominen 2011-01-30 09:03:48 CET
(In reply to comment #6)
> Fixed in Orage 4.8.0.5 in git now.
> 
> I can't test this though as I do not have access to libnotify 0.7.0, so it
> would be nice if somebody could
> confirm that compile now works.

Huomenta :)

And it works, just tested your patch. Thanks a lot
Comment 8 juha editbugs 2011-05-31 22:37:26 CEST
Fixed in 4.8.1

Bug #7204

Reported by:
Samuli Suominen
Reported on: 2011-01-29
Last modified on: 2011-05-31

People

CC List:
0 users

Version

Attachments

Fix the code for libnotify-0.7 (933 bytes, patch)
2011-01-29 15:00 CET , Samuli Suominen
no flags

Additional information