! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-mpc-plugin-0.3.5 always display 'pause' simbol on play/pause button
Status:
RESOLVED: WONTFIX
Product:
Xfce4-mpc-plugin
Component:
General

Comments

Description Ikonta 2010-12-18 10:14:57 CET
Created attachment 3289 
play/pause symbol example

This symbol should be at least (and easy to do) changed to 'play/pause' symbol (see the example image attached).

Or (better): blinking image (lite it's done in gmpc):
If mpd is playing --- display 'pause' symbol.
If mpd is paused or stopped --- display standard 'play' symbol.
Comment 1 Landry Breuil editbugs 2010-12-18 11:29:00 CET
I've wanted to do that for quite a long time, it's somewhere on my todolist. patches welcomed of course :)
Comment 2 Landry Breuil editbugs 2010-12-19 23:40:29 CET
and now i remember why i didn't do it yet: atm there's no g_timer doing somthing every X seconds, every call to mpd status is done upon an action from the user (mouseover on the plugin). If i want to manually refresh the icon every X seconds, i have to add a g_timer just for that..
Comment 3 Ikonta 2010-12-22 13:48:07 CET
What about do the simple and quick thing (rewrite the pictogram)?

And I see no need in refresh icon each N seconds.

It should be refreshed if:
1. Mouse click on play/pause button;
2. mpd is playing and mouse click on stop button;
3. After mpd stops to play the last track in list (and the loop mode is not set). I'm not familiar with developing for mpd, so I don't know the event, which should be regidtered in this case).
Comment 4 Landry Breuil editbugs 2010-12-22 14:10:10 CET
Yeah, and consider the following usecase :

 i also run gmpc on this computer (or others computers, or other mpd clients), and sometimes i stop/pause/start mpd from there. How does the mpc panel plugin detects that the play status changed and has to update to picture, without resorting to a timer periodically checking the actual status ?

of course it's easy to update the icon when the change comes from mpc plugin itself, but that would only be doing half of the work.
Comment 5 Landry Breuil editbugs 2012-04-16 12:45:06 CEST
It's likely WONTFIX as i dont want to maintain a permanent connection to mpd just to check the status..
Comment 6 Ikonta 2012-04-22 18:29:34 CEST
(In reply to comment #5)
> It's likely WONTFIX as i dont want to maintain a permanent connection to mpd
> just to check the status..

Excuse me for reopening.
But what about not changing appliction behaviour to change the button pictogram?
From current ('pause' only) to standard (in all seen hardware players) '_play_/pause' (like on attached image).
Comment 7 Landry Breuil editbugs 2012-04-22 21:14:10 CEST
(In reply to comment #6)
> (In reply to comment #5)
> > It's likely WONTFIX as i dont want to maintain a permanent connection to mpd
> > just to check the status..
> 
> Excuse me for reopening.
> But what about not changing appliction behaviour to change the button
> pictogram?
> From current ('pause' only) to standard (in all seen hardware players)
> '_play_/pause' (like on attached image).

There's no play/pause icon in the icon naming spec, so i'd have to carry and use my own icon which wouldnt match the user theme....

Bug #7011

Reported by:
Ikonta
Reported on: 2010-12-18
Last modified on: 2012-04-22

People

Assignee:
Landry Breuil
CC List:
0 users

Version

Version:
unspecified

Attachments

play/pause symbol example (849 bytes, image/png)
2010-12-18 10:14 CET , Ikonta
no flags

Additional information