! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fails to build with binutils-gold
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description Lionel Le Folgoc 2010-12-12 13:02:30 CET
Created attachment 3273 
Proposed patch

Hi,

The file lib/screenshooter-capture.c uses XKeysymToKeycode(), which is a libx11 symbol, and XShapeGetRectangles(), which is a libxext symbol, without explicitely linking with them. This makes the build fail with stricter linkers such as gold.

I updated locally ./Makefile.in to add -lXext -lX11 to LIBS, and it builds fine here, so I think it's the only issue.

See attached patch for a cleaner fix (I'm not an autotools guru, so this can probably be improved). I didn't test it very carefully though. ;)

Thanks!
Comment 1 Jérôme Guelfucci editbugs 2011-02-27 17:38:48 CET
Patch finally pushed to git master! Thanks a lot!

Bug #6971

Reported by:
Lionel Le Folgoc
Reported on: 2010-12-12
Last modified on: 2011-02-27

People

Assignee:
Jérôme Guelfucci
CC List:
0 users

Version

Version:
unspecified

Attachments

Proposed patch (850 bytes, patch)
2010-12-12 13:02 CET , Lionel Le Folgoc
no flags

Additional information