! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Customizing the button layout doesn't work
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfwm4
Component:
Settings

Comments

Description Mike Massonnet editbugs 2010-11-14 12:23:05 CET 
When you try to customize the button layout (xfwm4-settings) you get a corrupted layout that you can't repair. Well you can but it's tricky.

I can reproduce this with latest git master.
Comment 1 Jannis Pohlmann editbugs 2010-11-14 12:47:49 CET 
I found out two things:

1. From GTK+ 2.20 on we have to use gtk_buildable_get_name() instead of 
   gtk_widget_get_name() to obtain the ID of the buttons in the glade file.
   This can be fixed easily.

2. Dragging layout buttons results in a number of warnings. Something seems 
   to be broken here as well.
Comment 2 Jannis Pohlmann editbugs 2010-11-14 12:59:27 CET 
Ok, the drag source and target IDs were also obtained using gtk_widget_get_name() which is wrong. Fixed in master:

commit a3225e2e116a68833994349c949cd6fb0b6fdaae
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Nov 14 12:56:27 2010 +0100

    Fix broken button layouts by obtaining button IDs correctly (bug 6824).
    
    Since GTK+ 2.20, gtk_buildable_get_name() needs to be used instead of
    gtk_widget_get_name() (which always returns 'GtkButton' in this case).
Comment 3 Mike Massonnet editbugs 2010-11-16 08:32:52 CET 
*** Bug 6828 has been marked as a duplicate of this bug. ***
Comment 4 Landry Breuil editbugs 2010-11-26 09:14:57 CET 
*** Bug 6797 has been marked as a duplicate of this bug. ***
Comment 5 Mike Massonnet editbugs 2010-11-27 09:59:51 CET 
*** Bug 6878 has been marked as a duplicate of this bug. ***

Bug #6824

Reported by:
Mike Massonnet
Reported on: 2010-11-14
Last modified on: 2010-11-27
Duplicates (3):
  • 6797 title bar items config dialog doesn't work anymore
  • 6828 Button Layout doesn't work in 4.7.0
  • 6878 4.8pre1 => button layout problem

People

Assignee:
Jannis Pohlmann
CC List:
4 users

Version

Version:
unspecified
Target Milestone:
Xfce 4.6

Attachments

Additional information