! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
XK_Num_Lock undeclared when building xfce4-settings-4.7.3 on Solaris
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Keyboard Settings

Comments

Description Peter Tribble 2010-11-05 20:20:40 CET
Compile of xfce-settings-4.7.3 fails with:

gmake[2]: Entering directory `/var/tmp/xfce47/xfce4-settings-4.7.3/xfce4-settings-helper'
  CC     xfce4_settings_helper-keyboards.o
keyboards.c: In function `xfce_keyboards_helper_restore_numlock_state':
keyboards.c:236: error: `XK_Num_Lock' undeclared (first use in this function)
keyboards.c:236: error: (Each undeclared identifier is reported only once
keyboards.c:236: error: for each function it appears in.)
gmake[2]: *** [xfce4_settings_helper-keyboards.o] Error 1
gmake[2]: Leaving directory `/var/tmp/xfce47/xfce4-settings-4.7.3/xfce4-settings-helper'
gmake[1]: *** [all-recursive] Error 1

Which seems to imply that whichever header file declares XK_Num_Lock isn't being #include'd

On Solaris, this would be

#include <X11/keysym.h>

and adding that to keyboards.c fixes the problem for me, but I have no idea whether that fix is generally correct.

(This seems to be a side-effect of the fix for #3098.)
Comment 1 Jérôme Guelfucci editbugs 2010-11-05 21:02:35 CET
Thanks for your bug report, I just pushed a fix in git master.

Bug #6778

Reported by:
Peter Tribble
Reported on: 2010-11-05
Last modified on: 2010-11-05

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

Additional information