Created attachment 3059 Missing libxfcegui4 XDT check and LIBS/CFLAGS. Because xfce4-panel-4.7 is now using libxfce4ui instead of libxfcegui4, this is required or otherwise build bails out on: xfce4_wavelan_plugin-wavelan.o: In function `wavelan_configure': wavelan.c:(.text+0xed9): undefined reference to `xfce_create_header' Attached patch fixes the issue
Fixed too, thanks.
nice
There's a typo in the patch, see following diff: diff --git a/panel-plugin/Makefile.am b/panel-plugin/Makefile.am index 5e06216..61d06b1 100644 --- a/panel-plugin/Makefile.am +++ b/panel-plugin/Makefile.am @@ -10,9 +10,9 @@ plugin_PROGRAMS = xfce4-wavelan-plugin #plugin_LTLIBRARIES = \ # libwavelan.la -xfce4_wavelan_plugin_LDFLAGS = \ +xfce4_wavelan_plugin_LDADD = \ @LIBXFCE4PANEL_LIBS@ \ - @LIBXFCEGUI4L_LIBS@ + @LIBXFCEGUI4_LIBS@ xfce4_wavelan_plugin_SOURCES = \ wavelan.c \ (not so sure about the s/LDFLAGS/LDADD/ but it seems that it's the norm elsewhere).
Thanks for noticing. Just applied (and pushed) your fix. As for the difference between LDADD and LDFLAGS, LDADD is indeed the correct one here. If you look at the generated Makefile, the parameters passed to the linker are, first the LDFLAGS, then the list of .o files, then the LDADD. The order of the object files and libraries passed to the linker matters, and dependencies should appear after things that depends on them, otherwise, the linker might discard them as unneeded. It will do just that for example if you use the -Wl,--as-needed parameter as part of LDFLAGS, which is something some (most?) distributions do.