! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-cellmodem-plugin-0.0.5 fails to build with xfce4-panel-4.7 (missing lib...
Status:
RESOLVED: WONTFIX
Priority:
Medium
Severity:
normal
Product:
Xfce4-cellmodem-plugin
Component:
General

Comments

Description Samuli Suominen 2010-08-07 14:59:28 CEST 
Created attachment 3056 
Missing libxfcegui4 linking

Because xfce4-panel is using libxfce4ui instead of libxfcegui4 the CFLAGS and LIBS won't get inherited anymore. 

Build bails out on:

xfce4_cellmodem_plugin-pin_helper.o: In function `pin_helper_pin_entry_callback':
pin_helper.c:(.text+0xa6): undefined reference to `xfce_warn'

Also similar problems with linking when -Wl,--as-needed is used.

The attached patches will solve the issues.
Comment 1 Samuli Suominen 2010-08-07 14:59:56 CEST 
Created attachment 3057 
Fix "typing error", libs are passed from LDADD instead of LDFLAGS
Comment 2 Samuli Suominen 2010-08-07 15:00:42 CEST 
Sorry I know this bug went to wrong "Product" but "Panel Plugins" is missing xfce4-cellmodem-plugin!

Thanks, Samuli
Comment 3 Yves-Alexis Perez editbugs 2010-10-17 11:43:40 CEST 
Shouldn't cellmodem plugin be ported to libxfce4ui instead? :)
Comment 4 Samuli Suominen 2010-10-17 11:46:07 CEST 
(In reply to comment #3)
> Shouldn't cellmodem plugin be ported to libxfce4ui instead? :)

Absolutely, this is only the minimum patch required. 
Later it's easy to replace LIBXFCEGUI4 with LIBXFCEUI4.
Comment 5 Samuli Suominen 2010-10-17 14:10:06 CEST 
Created attachment 3146 
applies to current git
Comment 6 Samuli Suominen 2010-10-17 14:12:36 CEST 
Created attachment 3147 
Applies to current GIT master
Comment 7 Skunnyk editbugs 2018-09-16 19:36:42 CEST 
This project has been archived, so we are closing related bugs

Bug #6613

Reported by:
Samuli Suominen
Reported on: 2010-08-07
Last modified on: 2018-09-16

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
unspecified
Target Milestone:
---

Attachments

Missing libxfcegui4 linking (817 bytes, patch)
2010-08-07 14:59 CEST , Samuli Suominen 		no flags
Fix "typing error", libs are passed from LDADD instead of LDFLAGS (539 bytes, patch)
2010-08-07 14:59 CEST , Samuli Suominen 		no flags
applies to current git (1.07 KB, patch)
2010-10-17 14:10 CEST , Samuli Suominen 		no flags
Applies to current GIT master (835 bytes, patch)
2010-10-17 14:12 CEST , Samuli Suominen 		no flags

Additional information