6549 – Brightness cannot be adjusted when numlock is on

Brightness cannot be adjusted when numlock is on

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-power-manager

Component:

General

Comments

Description Konstantin Svist 2010-07-09 07:28:45 CEST

It's very odd.. whenever NumLock is on, Fn+down arrow (which is supposed to have effect of lowering brightness) doesn't do anything.
Without NumLock, it works fine.

I've booted into gnome Fedora 13 LiveCD and it works just fine with or without NumLock

Comment 1 Christoph Mende 2011-03-18 11:51:18 CET

18/000845 <+kalikiana> angelos: I had a keyboard issue with numlock in Midori, maybe it's the same problem
18/000904 <+kalikiana> the solution was to apply a state mask
18/001012 <+kalikiana> angelos: it was those 3 lines:
18/001012 <+kalikiana> #define MIDORI_KEYS_MODIFIER_MASK (GDK_SHIFT_MASK | GDK_CONTROL_MASK \
18/001012 <+kalikiana>     | GDK_MOD1_MASK | GDK_META_MASK | GDK_SUPER_MASK | GDK_HYPER_MASK )
18/001012 <+kalikiana> event->state = event->state & MIDORI_KEYS_MODIFIER_MASK;

This is most likely the issue. I wasn't able to try with that though since xfpm doesn't use GdkEventButtons and I have no idea how XfpmButtons work.

Comment 2 Christoph Mende 2011-06-28 13:01:57 CEST

Created attachment 3762 
grab the key with any modifier set

with this patch the key is grabbed regardless of any modifiers set. this means that it will also work together with shift, ctrl, caps lock, alt, any combination of those.
since I doubt any of those keys has a second meaning (ctrl+power for example), this shouldn't break anything.
in case it does, here are the possible modifiers:
>The valid keymask bits are: ShiftMask, LockMask, ControlMask, Mod1Mask, Mod2Mask, Mod3Mask, Mod4Mask, and Mod5Mask.
don't know which one of those is num lock, but if you need it, I can try to find it out.

Comment 3 Ali Abdallah editbugs

2011-09-09 11:03:51 CEST

version 0.8.x no longer supported.

Comment 4 Christoph Mende 2011-09-09 18:50:16 CEST

My patch is against 1.0.10, please reopen...

Comment 5 Christoph Mende 2011-09-30 06:38:30 CEST

This bug had been in power manager for over a year and has a patch applied for 3 months now... please reopen the bug and apply it, this bug is extremely annoying

Comment 6 Samuli Suominen 2011-10-29 16:33:24 CEST

Reopening as per Comment #4 and adjusting Version: field accordingly.

Comment 7 Lionel Le Folgoc 2012-01-31 10:53:56 CET

*** Bug 7997 has been marked as a duplicate of this bug. ***

Comment 8 Lionel Le Folgoc 2012-02-09 21:27:11 CET

*** Bug 8360 has been marked as a duplicate of this bug. ***

Comment 9 Yves-Alexis Perez editbugs

2012-02-21 23:24:54 CET

It seems that without this patch, at least on my x201s, brightness keys won't be detected at all, even without any modifier pressed.

Comment 10 Yves-Alexis Perez editbugs

2012-03-29 10:24:33 CEST

This one is still present in 1.0.11, could the patch be queued for 1.0.12?

Comment 11 Samuli Suominen 2012-03-30 16:27:32 CEST

(In reply to comment #10)
> This one is still present in 1.0.11, could the patch be queued for 1.0.12?

I second this request, 

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/xfce-extra/xfce4-power-manager/files/xfce4-power-manager-1.0.10-modifiers.patch?view=log

still applied cleanly on 1.0.11 release :-/

(Sorry for saying "Me too.")

Comment 12 Nick Schermer editbugs

2012-04-13 20:37:20 CEST

Applied in 4996f3d.

Bug #6549

Reported by:
Konstantin Svist

Reported on: 2010-07-09
Last modified on: 2012-04-13

Duplicates (2):

7997 Brightness hotkeys not being processed while num lock is on
8360 Power button don't work when numlock is enabled

People

Assignee:
Ali Abdallah

CC List:
7 users

Version

Version:
1.0.10

Target Milestone:
---

Attachments

grab the key with any modifier set (355 bytes, patch)
2011-06-28 13:01 CEST , Christoph Mende

no flags

Additional information