! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
RFE: "lock screen" should [optionally] send DPMS off signal
Status:
RESOLVED: MOVED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Konstantin Svist 2010-06-20 22:18:03 CEST
Created attachment 3014 
patch to force dpms off on 'lock screen'

"Lock Screen" in "when lid is closed" works fine, but I would like it to also send DPMS off signal to the screen.
This can either be hardcoded to happen always or added as an option ("Lock screen and switch display off")

I've modified my local copy to be hardcoded, feel free to use the patch if you want
Comment 1 Konstantin Svist 2010-06-20 22:27:18 CEST
Another possible solution is to add a global option "Lock screen when switching screen off" and/or "..when putting screen to sleep"
Comment 2 Konstantin Svist 2010-11-02 06:04:53 CET
problem still present in 1.0.1
Comment 3 Ali Abdallah editbugs 2010-12-19 13:09:15 CET
Hello, sorry for the late reply.

Actually i wanted to implement that, but it will be not a bug fix, so maybe for 1.1.x since i have to add some options that requires translations...
Comment 4 Jarno Suni 2014-01-02 22:33:06 CET
If you use "i3lock --dpms" to lock in xflock4, DPMS off signals are sent. (Even if you use the latter and accidentally move mouse, you can return to off-state by pressing Esc.) I think it is best, if the low-level screenlocker can handle the DPMS thing according to its configuration, so I suggest that you make a bug report against the screensaver/locker utility, if it can't do it well. I think it is best, if the locker can turn display off in the beginning AND after certain time of inacivity. That said, turning display off when closing the laptop lid is always the right thing to do. I would find it odd, if laptops don't do it always automatically.
Comment 5 Jarno Suni 2014-01-02 23:02:39 CET
Just like refrigerators do ;)
Comment 6 Jarno Suni 2014-01-03 01:21:46 CET
Just for clarification: you are not requesting to turn DPMS off, but to turn display off by DPMS. 

I admit that turning monitor off when locking is desirable sometimes, but some people may prefer e.g. to have some fancy animation with xscreensaver. One option could be to use xautolock as an alternative in xflock4. User could choose which command(s) to use for locking then, e.g. to have line
xautolock -nowlocker "xscreensaver-command -lock && xset dpms force off"
in autostarted applications. (And user would have to start xscreensaver there as well.)

One nice thing to do is to turn display on by DPMS after resuming from suspend or hibernate (when display is possibly locked). I think nobody have anything against that.
Comment 7 Konstantin Svist 2014-01-03 01:38:19 CET
That's right -- I'm asking to turn off the laptop display off by using DPMS.

I don't see a case where you'd want to keep the *laptop* screen on while it's closed.
I agree, there are cases where the desktop is "cloned" or "extended" to another display (usually external monitor/projector/etc.) -- those displays should not be affected, of course -- unless user explicitly specified they should be.

My previous laptop (from back when I filed the bug) apparently didn't turn off the LVDS backlight on lid close in hardware -- and instead relied on the OS to turn off the backlight.

DPMS at resume is a bad idea -- if user is waiting for laptop to wake up, they may expect to see the logged in environment. If they specified to use a blank screen screensaver, though - then sure :)
Comment 8 Jarno Suni 2014-01-03 08:43:31 CET
sidenote: changing DPMS enabled/disabled will break xfce4-power-manager's mode setting or "Monitor power management control" preference in general tab.
Comment 9 Jarno Suni 2014-01-03 10:22:58 CET
I think it could be nice, if there was a command line argument telling, if xflock4 should turn display off or not.
Comment 10 Jarno Suni 2014-01-03 18:10:57 CET
Personally, I keep the "when lid is closed" setting at "suspend". (I have had bad luck with "hibernate".) Laptop might heat too much, if you let it operate lid closed.

It might be complicated to give different displays different state in multi display system.
Comment 11 Konstantin Svist 2014-01-03 18:35:43 CET
And I use my laptop with 2 external monitors at work. And it's not the latest gen, so the video card only supports 2 screens -- so I close the laptop lid to save desk space (and to not block external monitors view)
Comment 12 Simon Steinbeiss editbugs 2014-06-30 13:20:15 CEST
To be honest I'm not sure this is really the right way to go. Screensavers or whatever handles the locking should determine whether to switch off the display or not (based on *their* configuration). Xfpm overriding that doesn't really make things better in my opinion.
So unless there are really good arguments for it, this is a wontfix for me.

> And I use my laptop with 2 external monitors at work. And it's not the latest gen, so the video card only supports 2 screens -- so I close the laptop lid to save desk space (and to not block external monitors view)

There is an option (at least in 1.3.0) to just switch off the display when the lid is closed, does that not do what you want?
Comment 13 Konstantin Svist 2014-06-30 18:52:34 CEST
I think we got kind of far away from the original RFE
From what I remember, back in 2010 I had a reasonably-common e1505 Dell laptop, which only disabled the LVDS backlight by software. Whenever I would close the lid, I expected the screen to lock with screensaver + turn off by DPMS. That's all this bug was about.
N.B. I don't even have that laptop anymore...


(In reply to Simon Steinbeiss from comment #12)
> To be honest I'm not sure this is really the right way to go. Screensavers
> or whatever handles the locking should determine whether to switch off the
> display or not (based on *their* configuration). Xfpm overriding that
> doesn't really make things better in my opinion.

I admit, I hate having PME options in multiple places -- one in power-manager, another in Xscreensaver options... but since you already have them in power-manager, at least make them work right.


> There is an option (at least in 1.3.0) to just switch off the display when
> the lid is closed, does that not do what you want?

Originally, no -- I expected the screen to lock as well.
Thanks for fixing bug 6515 btw!
Comment 14 Simon Steinbeiss editbugs 2014-06-30 21:01:17 CEST
(In reply to Konstantin Svist from comment #13)
> I admit, I hate having PME options in multiple places -- one in
> power-manager, another in Xscreensaver options... but since you already have
> them in power-manager, at least make them work right.

They do work right from my pov. Locking simply doesn't include switching off the display, it's as simple as that. You call a locktool/screensaver (which is whatever the user/distro defines) and that's it – responsibility for what happens next is up to the lockscreen.

FWIW, I haven't seen a laptop that didn't switch off its display when the lid was closed (no matter what action was executed), not sure xfpm really needs to interfere there.

> Originally, no -- I expected the screen to lock as well. Thanks for fixing bug 6515 btw!

YW :)
Comment 15 Git Bot editbugs 2020-05-27 01:36:27 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/1.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #6516

Reported by:
Konstantin Svist
Reported on: 2010-06-20
Last modified on: 2020-05-27

People

Assignee:
Ali Abdallah
CC List:
2 users

Version

Attachments

patch to force dpms off on 'lock screen' (1.27 KB, patch)
2010-06-20 22:18 CEST , Konstantin Svist
no flags

Additional information