! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Export variable DESKTOP_SESSION on init
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-session
Component:
General

Comments

Description Mike Massonnet editbugs 2010-04-10 11:32:39 CEST
When xfce4-session is init, currently it sets the X11 atoms _DT_SAVE/RESTORE_MODE to xfce4. This is one way that enables us to discover if the running session is Xfce or not.

A better way should be to export the environment variable DESKTOP_SESSION to xfce4.
Comment 1 Nick Schermer editbugs 2010-11-15 23:42:26 CET
Reassign to xfce-bugs@xfce.org.
Comment 2 Jérôme Guelfucci editbugs 2011-01-13 00:48:10 CET
Created attachment 3347 
Set DESKTOP_SESSION in xinitirc.

Is everybody ok with this?
Comment 3 Nick Schermer editbugs 2011-01-13 13:20:45 CET
Maybe we should check if this is not set.
Comment 4 Jérôme Guelfucci editbugs 2011-01-13 23:16:25 CET
Pushed to git master with a check.
Comment 5 Robby Workman editbugs 2011-01-20 15:24:49 CET
Reopening this, because this commit breaks starting X from runlevel 3 for us (Slackware).

GDM/KDM/other gui login managers have always been the only things that set DESKTOP_SESSION, so we check to see if that's set to know whether we should call "ck-launch-session xfce4-session" (runlevel 3) or just plain "xfce4-session" (GDM/KDM/etcetera).

It seems that it would be better to export some other variable to know that Xfce is the running session - for example, KDE uses KDE_FULL_SESSION or some such.
Comment 6 Mike Massonnet editbugs 2011-08-28 16:43:04 CEST
Hi Robby,

The bug has been reopened because it relates to the console-kit issues and something else related to Slackware specifically.

I don't believe we will fix this issue, but it should be opened in a new bug.

Ideally you would never need to call ck-launch-session, but currently it's what f.e. even ArchLinux recommends when starting from a TTY. Patching Xfce to call ck-launch-session is a quick-n-dirty hack, but it's not what the DE should be handling, and is something Xfce will never do (Jannis's been there done that and reverted it.)

Cheers,
Mike

Bug #6376

Reported by:
Mike Massonnet
Reported on: 2010-04-10
Last modified on: 2011-08-28

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
Unspecified

Attachments

Set DESKTOP_SESSION in xinitirc. (939 bytes, patch)
2011-01-13 00:48 CET , Jérôme Guelfucci
no flags

Additional information