Created attachment 2921 Port to libxfce4ui and GtkBuilder In attachment, a patch to port the xfce4-notifyd component (git version) to libxfce4ui and GtkBuilder.
Created attachment 2922 Port to libxfce4ui and GtkBuilder
Applied fine, clean patch :)
Coding style issues with function arg alignment in the 2 calls to gtk_icon_theme_load_icon() in that patch. Please fix. GTK_ICON_LOOKUP_FORCE_SIZE is only available in gtk 2.14 and later, but configure.ac.in only specifies gtk 2.10.0 as a requirement. Since this isn't a critical feature, please add the following to the top of the 2 files that use this: #if !GTK_CHECK_VERSION(2, 14, 0) #define GTK_ICON_LOOKUP_FORCE_SIZE 0 #endif The committer author says "Sunnyk" as the name. Please re-commit with a full name. With these fixes, I'd be happy to check your patch in.
Brian: libxfce4ui already depends on gtk 2.14, so why don't we bump the required gtk version to 2.14 too, that will not change anything, right?
That's a shame, but I suppose can't be helped. Reporter: in that case, please update configure.ac.in as well in the next version of the patch.
Created attachment 2932 Port to libxfce4ui and GtkBuilder New version of patch with consideration of comments (coding style, bump gtk version etc). Hope all is ok.
Works great here. Patch checked in as rev f1169d8. Thanks so much!