! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Invalid client ids are kept instead of replaced by the one returned by the SM
Status:
RESOLVED: INVALID
Priority:
Medium
Severity:
normal
Product:
Libxfcegui4
Component:
General

Comments

Description David Mohr 2010-03-18 02:53:45 CET 
This is valid for 4.6.3.

The problem is that after calling SmcOpenConnection session_client->client_id and session_client->given_client_id are compared, but the client_id is not updated to be given_client_id if they differ.

Similarly, the client id should get replaced in the restart command if it differs from the one that's present.
Comment 1 David Mohr 2010-03-18 18:38:23 CET 
Created attachment 2890 
Patch to replace the client id in the commands if it changed
Comment 2 Olivier Fourdan editbugs 2010-03-18 19:18:18 CET 
Do you have a test case that shows the need for that?
Comment 3 David Mohr 2010-03-18 19:39:37 CET 
The need for this is bug 5123.
Comment 4 Nick Schermer editbugs 2010-03-20 12:22:26 CET 
Brian could you take a quick look at this?
Comment 5 David Mohr 2010-03-20 19:22:48 CET 
Hm, this bug might be invalid. I just tried to confirm my assumption by running 'xfdesktop --quit; xfdesktop --sm-client-id invalid', then save my session, and the restart command is correctly saved - even without this patch.

Sorry about the fuss, and thanks for having a look Nick. Seems like the problem lies elsewhere.

Bug #6317

Reported by:
David Mohr
Reported on: 2010-03-18
Last modified on: 2010-03-20

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
unspecified
Target Milestone:
---

Attachments

Patch to replace the client id in the commands if it changed (3.01 KB, text/plain)
2010-03-18 18:38 CET , David Mohr 		no flags

Additional information