Hey, trying to reconfigure my orage clock panel plugin, I looked at the new TZ configuration stuff, and it displays garbage at the GMT offset. Nothing crashes, but it doesn't look good, especially if it's memory stuff which is displayed there. A screenshot is attached.
Created attachment 2876 screenshot of the problem
Oh, and clicking on “change mode” crashes the plugin
I can reproduce this.
Well, I could reproduce the crash, but not the garbage. I believe you get the same results from orage timezone selection also? Would you have time to modify debug variable to value 4 in tz_zoneinfo_read.c: static int debug = 4; /* bigger number => more output */ and then run orage like: orage > test.txt and send the test.txt to me. It will be fairly big. the crash should be fixed by modifying tz_zoneinfo_read.c: Add in_file = NULL; After line 605: static int check_parameters() { char *s_tz, *last_tz = NULL, tz[]="/zoneinfo", tz2[]="zoneinfo/"; int tz_len, i; struct stat in_stat; FILE *par_file; struct stat par_file_stat; if (debug > 1) printf("check_parameters: start\n"); in_file = NULL; par_file = fopen(TZ_CONVERT_PAR_FILE_LOC, "r"); if (par_file != NULL) { /* does exist and no error */
crash fixed in GIT in Orage 4.7.5.17. Can't reproduce the garbage though.
I get the garbage now in my 64 bit test environment.
Finally fixed that in Orage 4.7.6.3. Available in git. This only happened in systems where long was more then 4 bytes wide.
in 4.8.0