Add slock[0] (a Simple X display locker) functionality to xflock4 script File: xfce-utils/scripts/xflock4 Patch: --- xflock4 2009-10-14 14:52:56.114312329 +0300 +++ xflock4.slock 2010-02-25 14:05:59.094354611 +0200 @@ -23,6 +23,8 @@ xscreensaver-command -lock elif test x"`which gnome-screensaver-command 2>/dev/null`" != x""; then gnome-screensaver-command --lock +elif test x"`which slock 2>/dev/null`" != x""; then + slock else xlock $* fi [0]: http://tools.suckless.org/slock
Applied in 306869d18a9bb3e87ca67f1ac825560fd4454e62.
Err, do we really want to support "slock"? I find it very confusing, it doesn't display even a prompt, so that one has to type blindly the password to unlock the screen (or am I missing something?)
but there isnt anything xfce team have to support. It is an external program like xscreensaver or gnome-screensaver. With ctl+alt+del xflock4 is enabled and it would be nice to enable screen lock with any of lockers a user maybe have. Isnt that the idea behind xflock4 ?
Maybe there should be some kind of fallback to what the user decided to use, but the script can't support each and every screenlocker, imho. And yes, by adding them to xflock4, we are kind of promoting their use in Xfce, which means we do support them, in a way.
You install these kind of locking tools on purpose, so I didn't seen any problems with it. However we could add a environment variable fallback, so you only have to put XFLOCK4_COMMAND in your bash profile for alternative apps?
*** Bug 5121 has been marked as a duplicate of this bug. ***