! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar should link to libX11 and libm for 2 symbols
Status:
RESOLVED: FIXED

Comments

Description Kevin Fenzi 2010-02-14 02:22:01 CET
Greetings. There are 2 places where Thunar 1.0.1 links to a libary and depends on that library to link to libX11 and libm for some of it's symbols. It should explicitly link to those libraries. 

See: 

https://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking

This is a patch to work around that for now. You may want to solve it in a better way... 

diff -Nur Thunar-1.0.1.orig/thunar/Makefile.in Thunar-1.0.1/thunar/Makefile.in
--- Thunar-1.0.1.orig/thunar/Makefile.in	2009-04-18 08:41:06.000000000 -0600
+++ Thunar-1.0.1/thunar/Makefile.in	2010-02-13 18:06:06.000000000 -0700
@@ -372,7 +372,7 @@
 INTLTOOL_XML_NOMERGE_RULE = @INTLTOOL_XML_NOMERGE_RULE@
 INTLTOOL_XML_RULE = @INTLTOOL_XML_RULE@
 LD = @LD@
-LDFLAGS = @LDFLAGS@
+LDFLAGS = @LDFLAGS@ -lX11
 LIBFAM_CFLAGS = @LIBFAM_CFLAGS@
 LIBFAM_LIBS = @LIBFAM_LIBS@
 LIBFAM_REQUIRED_VERSION = @LIBFAM_REQUIRED_VERSION@
diff -Nur Thunar-1.0.1.orig/thunar-vfs/Makefile.in Thunar-1.0.1/thunar-vfs/Makefile.in
--- Thunar-1.0.1.orig/thunar-vfs/Makefile.in	2009-04-18 08:41:03.000000000 -0600
+++ Thunar-1.0.1/thunar-vfs/Makefile.in	2010-02-13 16:51:16.000000000 -0700
@@ -202,7 +202,7 @@
 thunar_vfs_font_thumbnailer_1_LINK = $(LIBTOOL) --tag=CC \
 	$(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=link $(CCLD) \
 	$(thunar_vfs_font_thumbnailer_1_CFLAGS) $(CFLAGS) \
-	$(thunar_vfs_font_thumbnailer_1_LDFLAGS) $(LDFLAGS) -o $@
+	$(thunar_vfs_font_thumbnailer_1_LDFLAGS) $(LDFLAGS) -lm -o $@
 am_thunar_vfs_mime_cleaner_1_OBJECTS =  \
 	thunar_vfs_mime_cleaner_1-thunar-vfs-mime-cleaner.$(OBJEXT)
 thunar_vfs_mime_cleaner_1_OBJECTS =  \

Here are the symbols/errors: 

/usr/bin/ld: thunar_vfs_font_thumbnailer_1-thunar-vfs-font-thumbnailer.o: undefined reference to symbol 'rint@@GLIBC_2.2.5'
/usr/bin/ld: note: 'rint@@GLIBC_2.2.5' is defined in DSO /lib64/libm.so.6 so try adding it to the linker command line

and

/usr/bin/ld: Thunar-thunar-gdk-extensions.o: undefined reference to symbol 'XQueryPointer'
/usr/bin/ld: note: 'XQueryPointer' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation
Comment 1 Lionel Le Folgoc 2011-03-29 21:17:34 CEST
It seems to be fixed in 1.2.x.

Bug #6232

Reported by:
Kevin Fenzi
Reported on: 2010-02-14
Last modified on: 2011-03-29

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

Additional information