If I check the "stay on top" flag in the plugin Properties window, the notes window opened when clicking on the notes plugin is not on top. If I switch the on-top flag from the window menu then it works, but only for the time while the window is active. After closing the window the stay on top effect is lost again
(In reply to comment #0) > If I check the "stay on top" flag in the plugin Properties window, the notes > window opened when clicking on the notes plugin is not on top. This sets the default options for new created note-groups/windows. > If I switch the on-top flag from the window menu then it works, but only for > the time while the window is active. After closing the window the stay on top > effect is lost again I'm unable to reproduce this with the code currently in git. Can you build the plugin from git? Maybe it is specific to the window manager, it works here fine with xfwm4 and compiz, which one are you using?
Same behaviour with openbox and xfwm4, it's not window-manager dependant. I will try to build it from git
@Mike: why you did not mention this commit http://git.xfce.org/panel-plugins/xfce4-notes-plugin/commit/?id=5091157c758f67fbdbe8a0c0a5bd1ade23bdebe1 ? seems like you fixed it before comment 1
(In reply to comment #3) > @Mike: why you did not mention this commit > http://git.xfce.org/panel-plugins/xfce4-notes-plugin/commit/?id=5091157c758f67fbdbe8a0c0a5bd1ade23bdebe1 > ? seems like you fixed it before comment 1 Is this the bug you are encounter? If so then there is a miss-ambiguity in the vocabulary used here. "Stay on top" is to me "Always on top" and not "Sticky". I catched a problem with the "sticky" window during the last days after doing the last release :( I was catching and fix all the bugs I could found today, I wasn't sure if it was related to this one.
really really sorry I misread the commit! :( I am getting these errors when trying to compile xfce4-notes-plugin: main-panel-plugin.vala:38.12-38.35: error: The name `create_panel_button' does not exist in the context of `Xfce' button = Xfce.create_panel_button (); ^^^^^^^^^^^^^^^^^^^^^^^^ main-panel-plugin.vala:60.17-60.25: error: The name `Icon' does not exist in the context of `Xfce' var pixbuf = Xfce.Icon.load ("xfce4-notes-plugin", size); ^^^^^^^^^ main-panel-plugin.vala:60.8-60.59: error: var declaration not allowed with non-typed initializer var pixbuf = Xfce.Icon.load ("xfce4-notes-plugin", size); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ main-panel-plugin.vala:61.8-61.13: error: The name `pixbuf' does not exist in the context of `NotesPlugin..new._lambda2_' if (pixbuf == null) ^^^^^^ main-panel-plugin.vala:62.5-62.10: error: The name `pixbuf' does not exist in the context of `NotesPlugin..new._lambda2_' pixbuf = Xfce.Icon.load (Gtk.STOCK_EDIT, size); ^^^^^^ main-panel-plugin.vala:63.27-63.32: error: The name `pixbuf' does not exist in the context of `NotesPlugin..new._lambda2_' image.set_from_pixbuf (pixbuf); ^^^^^^ main-panel-plugin.vala:108.9-108.40: error: The name `PanelPluginRegisterExternal' does not exist in the context of `Xfce' return Xfce.PanelPluginRegisterExternal (ref args, panel_plugin_register); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Compilation failed: 7 error(s), 0 warning(s) What can it be? I have git versions of xfce4-dev-tools and xfce4-vala and my vala compiler is 0.7.9-1
Created attachment 2755 notes-above-debug-msg.patch Ah bad, the always-on-top option always used to be the way it is. If you want to compile for the xfce4-panel 4.6 you need to checkout the branch xfce-4.6 of xfce4-vala. The code in master has bindings for xfce4-panel 4.7. However instead of building the panel plugin you can also try with the standalone binary than runs in the notification area. Just run the following commands without installing/uninstalling further packages: $ cd xfce4-notes-plugin $ make -C lib $ make -C src xfce4-notes $ ./src/xfce4-notes Btw, make sure to remove the "plugin" from the notification area afterwards (right click > remove) cause it will automatically install an autostart file when run and this removes the file. Autostart files are manageable through xfce4-session-settings, they get installed usually under ~/.config/autostart. I make an attachement that can help you see what is going on with the always-on-top bit. Thanks for testing :)
Created attachment 2756 notes-reset-keep-above.patch Also, I believe this patch will be the only way to fix this issue. Let me know if it is the case.
Thanks, I was able to build xfce4-notes and run it. notes-reset-keep-above.patch fixes the "always on top" flag of the icon menu of the notes window; the "always on top" flag in Properties window still seems useless and not connected to the one of the notes window if you want I can also apply the debug patch and report
(In reply to comment #7) > Created an attachment (id=2756) [details] > notes-reset-keep-above.patch > > Also, I believe this patch will be the only way to fix this issue. Let me know > if it is the case. btw is this a vala glitch or what?
(In reply to comment #8) > Thanks, I was able to build xfce4-notes and run it. > > notes-reset-keep-above.patch fixes the "always on top" flag of the icon menu of > the notes window; the "always on top" flag in Properties window still seems > useless and not connected to the one of the notes window Ok, I'm gonna have a closer look at the patch before pushing it. As said earlier, the properties dialog lets you set parameters for newly created windows, it doesn't affect the existing ones. > if you want I can also apply the debug patch and report It won't help further, as this fix works for you I can commit it. (In reply to comment #9) > btw is this a vala glitch or what? Nope, something unexpected.
I'm able to reproduce always-on-top awkness on my netbook like you. I have GTK+ 2.16.1 on it, what version of GTK+ are you running?
I am running up-to-date Arch Linux with packages: * gtk2 2.18.5-1 * gtk-xfce-engine 2.6.0-1 * gtk 1.2.10-9 * glib 1.2.10-8 * glib2 2.22.3-1 * gtkmm 2.18.2-1
(In reply to comment #10) > > the notes window; the "always on top" flag in Properties window still seems > > useless and not connected to the one of the notes window > > Ok, I'm gonna have a closer look at the patch before pushing it. As said > earlier, the properties dialog lets you set parameters for newly created > windows, it doesn't affect the existing ones. > Ok, looks like I am not understanding the feature because I never got more than 1 window from the notes plugin. Perhaps there is a way to pop up more windows from that plugin? Anyway if I close the window, change the always-on-top option from properties, then pop up a notes window, nothing has changed related to the always-on-top flag (but seems like you are already aware of this or that it is expected behaviour). > (In reply to comment #9) > > btw is this a vala glitch or what? > > Nope, something unexpected. > Something /interesting/ also...
Pushed into git. It's slighty different, the above state is set directly after hiding the window (which causes the loss of this state). You can create new windows via Shift+Ctrl+N (or open the window menu, go to the sub-menu Go, and select "new notes group").
all clear Mike, thank you very much :)