! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
build failure with ld --no-add-needed
Status:
RESOLVED: FIXED

Comments

Description Yves-Alexis Perez editbugs 2009-11-04 22:18:30 CET
Created attachment 2653 
fix build failure with ld --no-add-needed

Hi,

someone in Debian tried to build exo with binutils-gold which apparently sets
--no-add-needed as default. The builds fails because of missing explicit lib
declarations, I've tried to fix them, so here's the result.

It's against stable branch (0.3.105 tag, though it doesn't exist in bugzilla).

Cheers,
Comment 1 Yves-Alexis Perez editbugs 2009-11-05 07:49:12 CET
Created attachment 2657 
fix build failure with ld --add-needed (binutils-gold)

Updated patch to use XDT_CHECK_LIBX11_REQUIRE()
Comment 2 Nick Schermer editbugs 2009-11-10 16:43:38 CET
Although I believe the patch is correct, it build fine here with -Wl,--no-add-needed...
Comment 3 Yves-Alexis Perez editbugs 2009-11-10 16:50:06 CET
Hmmh, maybe that's something else brought by binutils-gold then :/
I'll try to make you a build log tomorrow.
Comment 4 Nick Schermer editbugs 2010-02-15 11:30:06 CET
Applied parts of this patch that still applied in 00e1e90. Any news on this? If you think it is fixed, feel free to close the bug.
Comment 5 Nick Schermer editbugs 2010-05-04 07:32:42 CEST
Ping
Comment 6 Yves-Alexis Perez editbugs 2010-05-04 08:09:34 CEST
will try soon, sorry for delay :)
Comment 7 Yves-Alexis Perez editbugs 2010-05-05 06:37:09 CEST
0.5.2 seems to work fine with binutils-gold so I guess it's ok for now. Thanks for applying :)

Bug #5951

Reported by:
Yves-Alexis Perez
Reported on: 2009-11-04
Last modified on: 2010-05-05

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
0.3.105

Attachments

Additional information