! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfconf does not compile using Sun Studio
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfconf
Component:
General

Comments

Description William Bonnet 2009-06-17 20:15:09 CEST 
Created attachment 2405 
Fix problem by moving  G_GNUC_INTERNAL at the beginning of the line

G_GNUC_INTERNAL macro should be added at the be beginning of lines to compile
with Sun Studio compiler under solaris
Comment 1 William Bonnet 2009-06-17 20:15:33 CEST 
Created attachment 2406 
Fix problem by moving  G_GNUC_INTERNAL at the beginning of the line
Comment 2 William Bonnet 2009-06-17 20:16:09 CEST 
I added a distinct patch per file to modify
Comment 3 Brian J. Tarricone (not reading bugmail) 2009-06-17 20:25:49 CEST 
Please fix indentation to match the original files (line up function arguments on the next lines), and one patch for everything is fine.
Comment 4 William Bonnet 2009-06-17 21:37:51 CEST 
Created attachment 2407 
Fix indetation problem

This patch replace the previous patch to xfconf-gvaluefuncs.h.

File xfconf-locking-utils.h is not modified, there was no indentation problem
Comment 5 William Bonnet 2009-06-17 21:38:18 CEST 
Created attachment 2408 
Fix indetation problem
Comment 6 William Bonnet 2009-06-17 21:39:28 CEST 
I modified only the file with indentation problem. More patch to come for sun studio on other module.
Comment 7 Brian J. Tarricone (not reading bugmail) 2009-09-05 03:50:15 CEST 
Checked in, thanks (xfce-4.6 and master).  Sorry for the delay.

Bug #5477

Reported by:
William Bonnet
Reported on: 2009-06-17
Last modified on: 2009-09-05

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Version:
4.6.0
Target Milestone:
Future

Attachments

Fix problem by moving G_GNUC_INTERNAL at the beginning of the line (1.38 KB, patch)
2009-06-17 20:15 CEST , William Bonnet 		no flags
Fix problem by moving G_GNUC_INTERNAL at the beginning of the line (581 bytes, patch)
2009-06-17 20:15 CEST , William Bonnet 		no flags
Fix indetation problem (1.41 KB, patch)
2009-06-17 21:37 CEST , William Bonnet 		no flags
Fix indetation problem (1.41 KB, patch)
2009-06-17 21:38 CEST , William Bonnet 		no flags

Additional information