! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop doesn't support emblems for .desktop files
Status:
RESOLVED: FIXED
Priority:
Very Low
Severity:
enhancement
Product:
Xfdesktop
Component:
General

Comments

Description PC2st.ir 2009-06-15 10:11:39 CEST
xfdesktop doesn't support emblems for .desktop files... thx
Comment 1 Julien [nodiscc] editbugs 2011-02-15 04:51:45 CET
I'd like to add that xfdesktop doesn't seem to support emblems _at all_. The Properties dialog accessible from the desktop doesn't allow to set one. When one sets the emblem FROM THUNAR for, say, a folder on the Desktop, the emblem is never displayed on the desktop.

Desktop is one of the places where emblems would be the most useful (Users tend tu mess up their desktop).

Please add emblem support on the desktop.

Thanks
Comment 2 Eric Koegel editbugs 2012-03-17 14:55:10 CET
Created attachment 4266 
Add optional support for custom file icon emblems

Adds support to display multiple custom emblems for file icons on
the desktop. Regular file icons will display whether it's a symlink
or the file is read-only in addition to any emblems the user sets
in Thunar. This requires an optional dependency on libtdb to read
the metadata.
Comment 3 Eric Koegel editbugs 2012-03-20 19:09:43 CET
Created attachment 4273 
Add optional support for custom file icon emblems

Fixed a crash when an unmounted drive was present as well as clean up a small memory leak.
Comment 4 Eric Koegel editbugs 2012-03-20 19:20:33 CET
Created attachment 4274 
Add optional support for custom file icon emblems

Oops, accidently set xfdesktop_file_utils_get_icon to not use the emblem_list, fixed.
Comment 5 Eric Koegel editbugs 2012-03-24 08:54:53 CET
Created attachment 4279 
Add optional support for custom file icon emblems

xfdesktop --version now prints if custom file emblems are enabled.
Comment 6 Nick Schermer editbugs 2012-03-24 13:00:09 CET
Can't we use GIcon there?
Comment 7 Eric Koegel editbugs 2012-05-04 09:23:03 CEST
Created attachment 4391 
Add optional support for custom file icon emblems

Changed it to use gicon and I keep the gicon around so it doesn't
have to redo it when getting a different sized image. I also kept the
custom emblem drawing code rather than use gtk's version of random
placement so it's consistant with Thunar and the symlinks/read-only
emblems will show in predictable locations.
Comment 8 Eric Koegel editbugs 2013-09-30 09:11:03 CEST
This was added to master in:
http://git.xfce.org/xfce/xfdesktop/commit/?id=bc48d533bd0dbaaad8d865bd6f26bc9c8f47e042
Since GIO doesn't provide any way to track when metadata changes, there may
be up to a 1 minute delay before xfdesktop sees the any emblem updates.

Bug #5469

Reported by:
PC2st.ir
Reported on: 2009-06-15
Last modified on: 2013-09-30

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Attachments

Additional information