Hello, I noticed, by using notify-osd (a notification daemon that doesn't support "action" hints in notifications) that thunar-volman was not checking for the notification server caps before adding actions to the "can't unmount volume now, data being written" notification. The correct behaviour would be to get server caps, and to only add the action if : 1) the server supports actions, to avoid unwanted behaviour 2) the action is actually useful (i'm not sure but i think it's merely a "Ok" button here. What action *is* required apart from *waiting* in this case ?) Cordially, SD.
Created attachment 2541 workaround used in xubuntu (with notify-osd) Afaik, it's not in thunar-volman, but in exo. And the issue isn't with an action, but with a non-expiring notification (notify-osd doesn't support notifications using NOTIFY_EXPIRES_NEVER). In a certain manner, this is specific to notify-osd (only in ubuntu atm), so this is ok if it's not fixed in exo. But I think an interesting idea could be to replace the "don't unplug, writing data" notification with a temporary dialog with a throbber (or something like that), because the notification stuff is not very ideal with very slow usb keys. When writes are done, this dialog could disappear, and a notification saying "ok to unplug" (this is already the case currently) displayed. Well, I'm not an ui designer anyway, this is just an idea. ;)
Jerome/Jannis, this moved to thunar, anything we need to fix this, maybe in the notification daemon?
Notifications are now sent from thunar and from xfdesktop to the notification daemon. So we need to check the server caps in thunar-notify.c and xfdesktop-notify.c.
Yeah, xfce4-notifyd already sends the its server caps on request, so everything is fine considering that side.
Still I wonder what would be a good alternative to the non-expiring notification? Dialogs are not. Notifications with a throbbler could be. To bad Canonical decided to drop non-expiring notifications entirely in their implementation. Really, as long as there is no good alternative, I don't see how we could change this without making things worse. Expiring notifications... maybe. But those are kinda bad in this case.
Moving, since this is not related to exo anymore.