! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix crash when the device has no device-name
Status:
RESOLVED: FIXED
Product:
Xfce4-mixer
Component:
General

Comments

Description Landry Breuil editbugs 2009-04-08 09:11:51 CEST
(Olready sent you in an e-mail)
fix found by ajacoutot@openbsd.org :
device_name should be initialized to null in 
libxfce4mixer/libxfce4mixer.c:_xfce_mixer_filter_mixer(), otherwise the 
G_LIKELY can fail.
With this fix, i only get the glib warning (xfce4-mixer:12023):
GLib-GObject-WARNING **: IA__g_object_get_valist: object class
`GstSunAudioMixer' has no property named `device-name', but it doesn't 
badly segfault anymore.
The mixer shows as 'unknown device 0(GstSunAudioMixer)', which is a bit gross, but we have no way to get a correct device name atm.

while here, there's an easily fixable warning in xfce4-mixer/:
main.c:89: warning: implicit declaration of function 'xfce_err'
Comment 1 Jannis Pohlmann editbugs 2009-04-08 12:14:22 CEST
Fixed in revision 29731:

        * libxfce4mixer/libxfce4mixer.c: Fix crash with backends where the
          GstMixer implementation has no "device-name" property (bug #5201).
Comment 2 Jannis Pohlmann editbugs 2009-04-08 12:14:55 CEST
And this for the second bug (also revision 29731:

        * xfce4-mixer/main.c: Include libxfcegui4.h to avoid implicit
          declaration of xfce_err().

Bug #5201

Reported by:
Landry Breuil
Reported on: 2009-04-08
Last modified on: 2009-07-14

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Attachments

Additional information