Hi, testing svn plugin 0.0.3, thunar segfaults when closing a window and svn plugin is in use. If i don't rightclick on a file/folder(and hence call some kind of initialization in svn plugin ?) it doesn't segfault. For each rightclick, i get this warning in console : (Thunar:774): GLib-GObject-WARNING **: gsignal.c:2267: signal `new-watch' is invalid for instance `0x8b008270' And here's thunar backtrace (not really helpful..) : Program received signal SIGSEGV, Segmentation fault. [Switching to process 774, thread 0x7d2c5000] 0x01920184 in ?? () (gdb) bt #0 0x01920184 in ?? () #1 0x00813a5a in __cxa_finalize (dso=0x0) at /usr/src/lib/libc/stdlib/atexit.c:153 #2 0x007ed7f2 in exit (status=0) at /usr/src/lib/libc/stdlib/exit.c:57 #3 0x1c014b65 in ___start () #4 0x1c014aaf in _start () #5 0x00000000 in ?? () (gdb) (plus a warning : (tsp-svn-helper:31479): GLib-GObject-WARNING **: invalid unclassed pointer in cast to `TshLogDialog' )
(In reply to comment #0) > Hi, > > testing svn plugin 0.0.3, thunar segfaults when closing a window and svn plugin > is in use. If i don't rightclick on a file/folder(and hence call some kind of > initialization in svn plugin ?) it doesn't segfault. > For each rightclick, i get this warning in console : > (Thunar:774): GLib-GObject-WARNING **: gsignal.c:2267: signal `new-watch' is > invalid for instance `0x8b008270' The signal `new-watch' should be `new-process', so that part is fixed. The segfault could be related to this, I'm not able to reproduce this. To test if the signal and the error are related. Open the context menu by right clicking on the background(in icon or compact-list view) instead of a file or folder, this will create the menu in a slightly different way in which already uses `new-process' instead of `new-process'. > (plus a warning : (tsp-svn-helper:31479): GLib-GObject-WARNING **: invalid > unclassed pointer in cast to `TshLogDialog' ) Could you give the steps to reproduce this warning. Which svn action(s) which buttons to click.
Clicking on the background doesn't yield the warning, but the segfault still occurs upon exiting. So it doesn't seem related to this warning. Regarding the other warning. i've not been able to find the steps needed to reproduce it, but the warning was shown _after_ thunar segfault. I'll see if it happens again.
The problem was in svn_cmdline_init. This adds apr_terminate() to atexit(). The libsvn init is changed and doen't use atexit(). Fixed in r7853.