5056 – Thunar wallpaper plugin does not work when there is a space in the path to the image

Thunar wallpaper plugin does not work when there is a space in the path to th...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Thunar

Component:

General

Comments

Description Jérôme Guelfucci editbugs

2009-03-07 13:38:31 CET

I guess everything is in the title...

I filed this under Thunar, as Thunar Wallpaper plugin is part of the thunar source package now.

Comment 1 Stephan Arts editbugs

2009-04-04 09:07:05 CEST

Created attachment 2271 
Possible fix, puts quotes around the filename.

Could you test this patch?

Comment 2 Mike Massonnet editbugs

2009-04-07 22:02:22 CEST

Created attachment 2275 
add quotes around filename (%s)

Comment 3 Mike Massonnet editbugs

2009-04-07 22:02:46 CEST

Forgot the comments, the attachment also fixes bug #5057

Comment 4 Mike Massonnet editbugs

2009-04-07 22:11:47 CEST

Created attachment 2276 
fixes

Same patch, with another fix that checks for gconftool-2 instead of gconftool. Looking for gconftool is unsafe as it doesn't get build anymore with this name out of the source tree.

Comment 5 Jérôme Guelfucci editbugs

2009-04-08 09:08:45 CEST

I just tested Mike's patch, it fixes the issue for me. Thanks Mike!

Comment 6 Stephan Arts editbugs

2009-04-18 14:28:18 CEST

*** Bug 5186 has been marked as a duplicate of this bug. ***

Comment 7 Stephan Arts editbugs

2009-04-18 15:28:52 CEST

committed, though I think this does not solve the problem when the filename contains quotes... should be fixed in next release.

Comment 8 Jérôme Guelfucci editbugs

2010-12-29 16:03:27 CET

Created attachment 3310 
Use g_shell_quote to quote the filename

This seems to work for all kinds of file names: normal, accents, quotes, spaces...

Comment 9 Jérôme Guelfucci editbugs

2010-12-30 00:33:45 CET

Patch pushed to git master.

Bug #5056

Reported by:
Jérôme Guelfucci

Reported on: 2009-03-07
Last modified on: 2010-12-30

Duplicates (1):

5186 thunar-wallpaper doesn't handle some file names gracefully

People

Assignee:
Jannis Pohlmann

CC List:
3 users

Version

Version:
1.0.0

Target Milestone:
1.0.0

Attachments

Possible fix, puts quotes around the filename. (1.40 KB, patch) 2009-04-04 09:07 CEST , Stephan Arts	no flags
add quotes around filename (%s) (2.15 KB, patch) 2009-04-07 22:02 CEST , Mike Massonnet	no flags
fixes (3.46 KB, patch) 2009-04-07 22:11 CEST , Mike Massonnet	no flags
Use g_shell_quote to quote the filename (3.45 KB, patch) 2010-12-29 16:03 CET , Jérôme Guelfucci	no flags

Additional information