angelos@odin ~ % xfce4-mouse-settings (xfce4-mouse-settings:11678): xfce4-mouse-settings-CRITICAL **: XI is not present or too old. In fact, it is too new. This is from the xfce4-settings build: main.c:1226: warning: 'XGetExtensionVersion' is deprecated (declared at /usr/include/X11/extensions/XInput.h:1241) and pointers.c:138: warning: 'XGetExtensionVersion' is deprecated (declared at /usr/include/X11/extensions/XInput.h:1241) This is not yet an issue for the average joe since my libXi is built from git (version 1.2.99.1 according to the xi.pc), but it will become one as soon as distros start shipping libXi 1.3 (Xorg 7.5 I guess)
Created attachment 2166 fix xi check for xi 2.0 major_version.minor_version are 2.0 for libXi-1.3, so the logic in that check is broken here (minor_version is < 4), the above patch fixes that and uses the new XQueryInputVersion instead of XGetExtensionVersion, but it introduced a minor flaw.. the if evaluates to true with Xi 0.5-0.9, shouldn't be a problem though as the lowest version available seems to be 1.0
Created attachment 2167 new patch actually... here's a patch without said flaw
Created attachment 2168 real new patch eh, attached the old one before, sorry for the spam
Using XQueryInputVersion also enables the internal xi2 support, so i'm not sure this works with our code.
Created attachment 2170 Check for 1.4 using XQueryInputVersion How about this? Can you try if this works?
Not a 4.6 blocker since XI 2.x isn't out yet; scheduling for 4.6.1.
kind of works... the dialog starts up, but the devices list is empty, even when I set the major and minor in XQueryInputVersion to 0, 0 (which seems to be what's done internally when XGetExtensionVersion is used). anyway, my mouse is in the list with my patch
Is XI 2.0 backward compatible with XI 1.x? If not, we shouldn't be advertising support for 2.0 unless we actually support it properly...
And no, this is *not* going into 4.6.0. Only 4.6 blockers should go into trunk now.
(In reply to comment #8) > Is XI 2.0 backward compatible with XI 1.x? If not, we shouldn't be advertising > support for 2.0 unless we actually support it properly... No it's not, the returned data is not compatible, Therefore I tried XQueryInputVersion (xdisplay, 1, 4); which _should_ make X internally fallback to the old behaviour. But that probably doesn't work. Anyway mpx will most likely be added in xorg 7.6 (if it's not delayed again), so it's not a really important to fix, but it would be nice if it works and fallsback to the old behaviour.
Looks like this is about to be an issue in Fedora 12 (not yet released). Fedora rawhide currently has libXi-1.2.99-11.20090825 and runs into this issue. ;( Any chance of a fix in a 4.6.2 or the like? :)
I think this can be closed, I'm not getting this anymore with libXi-1.4.2 and xfce4-settings-4.8. Any reason this is still open?