Hi, I have written a patch to allow the user to choose the hostname, port and password to connect to MPD. Could you please consider including it in xfmpc ? I am not so familiar with C and GTK, there might be some mistakes, please tell me if I can improve it. Vincent
Created attachment 2147 add dialog to choose the hostname, port and password
Hey thanks, I will review it and it already looks clean.
From a quick point of view: - It doesn't work with the MPD_HOST/PORT environment variables. - I haven't though yet of a general preferences dialog, I'll revert it to a "Server Settings" dialog (a better name than "Server" is welcome). - I will move the button to a menu item in the arrow button.
About the MPD_HOST/PORT environment variables, I think there is a mistake in xfmpc because it should be password@host and not host@password as it is in xfmpc (http://linux.die.net/man/1/mpc). That may be why it doesn't work for you. I have moved the button to the arrow button and renamed it to "Server Settings".
Created attachment 2148 updated patch
I commited a modified version of the patch (revision 6634) which takes care of other bits. Feel free to comment on it, but all in all it does its job well. Thanks for your contribution, and btw good catch with the password@host bug ;-) And by the way, as I'm not an MPD user for quiet some months anymore, I will enjoy further contributions.
I saw your commit, it looks better than my work :-) I would like to work on xfmpc. Did you intend to work on something specific or want something to be done. You wrote on the IDEAS file "XfmpcGoodies, a plugin interface on the right side pane", I don't understand what you mean by that.