! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
libxfcegui4: In 'Conflicting actions for %s' dialog, some strings are not loc...
Status:
RESOLVED: FIXED
Product:
Libxfcegui4
Component:
General

Comments

Description Masato Hashimoto 2009-01-07 13:04:12 CET
In 'Conflicting actions for %s' dialog of libxfcegui4, following strings are not localized, English strings are still displayed.

Description messages:
 * "This shortcut is already being used for another window manager action. Which action do you want to use?"
 * "This shortcut is already being used for the command '%s'. Which action do you want to use?"

I don't confirm other description messages in this dialog.

Button labels:
 * "Use '%s'"
 * "Keep the window manager action"
 * "Keep '%s'"

Build Date & Platform:
 Build 2009-01-07 on Arch Linux
Comment 1 Masato Hashimoto 2009-01-28 15:16:56 CET
Correct component.
Comment 2 Brian J. Tarricone (not reading bugmail) 2009-01-29 08:50:32 CET
It's just a missing translation; certainly not a release blocker.
Comment 3 Masato Hashimoto 2009-01-29 09:18:17 CET
No, there are no problems in Japanese translation at least as far as I confirmed.
Comment 4 Jannis Pohlmann editbugs 2009-01-29 12:51:18 CET
Masato, you're right. I'm using N_() to mark the strings for translation but I there's no gettext() call later when using these strings.
Comment 5 Jannis Pohlmann editbugs 2009-01-29 20:37:56 CET
(In reply to comment #4)
> Masato, you're right. I'm using N_() to mark the strings for translation but I
> there's no gettext() call later when using these strings.

Damn. That's not the only problem. The *real* issue here is that
libxfce4kbd-private is a shared library on its own and thus needs its own
translation files to be installed to $PREFIX/share/locale/. Right now, its
strings are translated as part of libxfcegui4 but that's wrong. I need to come
up with a solution for that.
Comment 6 Jannis Pohlmann editbugs 2009-01-29 21:19:25 CET
(In reply to comment #5)
> (In reply to comment #4)
> > Masato, you're right. I'm using N_() to mark the strings for translation but I
> > there's no gettext() call later when using these strings.
> 
> Damn. That's not the only problem. The *real* issue here is that
> libxfce4kbd-private is a shared library on its own and thus needs its own
> translation files to be installed to $PREFIX/share/locale/. Right now, its
> strings are translated as part of libxfcegui4 but that's wrong. I need to come
> up with a solution for that.

Ok, all of this should be fixed in revision 29410. I've added _() around the string variables that are marked with N_() wherever they are used. I've also added calls to xfce_textdomain() in several places of libxfce4kbd-private so that the translations are actually used.

Bug #4784

Reported by:
Masato Hashimoto
Reported on: 2009-01-07
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information