! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
playback control buttons should use GTK stock icons
Status:
CLOSED: FIXED
Severity:
enhancement
Product:
Xfmedia
Component:
general

Comments

Description Andrew Conkling 2004-11-07 05:49:17 CET
AFAICT, xfmedia uses icons in $PREFIX/icons/hicolor/22x22/actions (at least on my system 
there are xfmedia-*.png icons).  Why don't you just call on media-* icons?  I don't know if 
they're the standard, but they've been in all the themes I've used....
Comment 1 Brian J. Tarricone (not reading bugmail) 2004-11-07 07:30:14 CET
this is a bit tricky.  they're actually stock icons that i stole, and modified
to be squished a bit.  stock icons don't have to be any special name, so relying
on the name may not work.  they're actually not even square icons, so putting
them in /usr/share/icons/hicolor may not even be correct.  at any rate, it would
end up resizing the main window if the icons changed, so i don't really want to
do this.

on the other hand, i just changed the repeat and shuffle buttons to use themed
icons, or fall back to the xfmedia-* ones.

(note: Lila-AC is missing an icon for shuffle.)
Comment 2 Andrew Conkling 2004-12-12 06:42:44 CET
In my continuing theming efforts, I'm dredging this one up. :)

Is it not possible to have the themed picture show up out-of-aspect?  Then you 
could use a generic name and other themes would draw those icons similarly 
skewed.

If not, I'll just provide my particular icon theme of choice with some skewed 
files to replace the hicolor ones. ^_^
Comment 3 Brian J. Tarricone (not reading bugmail) 2004-12-12 09:19:44 CET
hmm, i just can't get this to work.

i stripped out the static loading and added some logic to add them as gtk stock
icons, but i can only get it to return the defaults that i embed in there (note
that i'm using the Lila-AC theme you gave me a while back, which has the stock
media icons).

so i'm not sure what to do.  gtk 2.5/2.6 has the media stock definitions
already, so it should (theoretically) work ok on its own, but my code to add the
stock icons to <=2.4 doesn't seem to work.  bah.
Comment 4 Brian J. Tarricone (not reading bugmail) 2004-12-12 10:41:05 CET
ok, that was a big mess, but it should theme them properly now.  it squishes the
icons on the fly to be the right size.  the icons in the systray menu are themed
now too.
Comment 5 Andrew Conkling 2004-12-12 13:36:44 CET
Rockin'.  Now if only there were a CVS ebuild for xfmedia (runs to the forums to 
check)....
Comment 6 Brian J. Tarricone (not reading bugmail) 2004-12-12 20:22:35 CET
might want to check in the files section off the xfmedia website... it's old,
but should still work.
Comment 7 Andrew Conkling 2004-12-31 07:11:39 CET
Well, in 0.6.0, it looks like the icons you're using are xfmedia-*, not media-*. 
 Is this intentional?  I'll add icons to the theme I use if necessary, but the 
media-* icons are already there....
Comment 8 Brian J. Tarricone (not reading bugmail) 2004-12-31 08:24:51 CET
nope, 0.6.0 uses stock icons directly.  gtk 2.6 includes GTK_STOCK_MEDIA_*, and
i add local copies with the same stock ids for versions < 2.6.
Comment 9 Andrew Conkling 2004-12-31 16:19:22 CET
So this should work pre-GTK-2.6?  Because I can't figure it out.  Looking at the 
code, it seems like I want to add the following to my iconrc:

stock ["GTK_STOCK_MEDIA_NEXT"] = {{ "path/to/my/icon" }}

but that doesn't pull in my theme's icon.  Am I doing something wrong?

Sorry to be a pest!
Comment 10 Brian J. Tarricone (not reading bugmail) 2004-12-31 22:49:59 CET
you want "gtk-media-next".  note that the rest of the gtk stock icons in the
iconrc file don't use the C macro name, but the stock id itself.  look in
src/xfmedia-common.h inside the #ifdef near the top for the correct names. 
frankly, i'm not sure if this actually works with gtk 2.4; i wrote the code
after i updated to 2.6.  but it *should* work.
Comment 11 Andrew Conkling 2005-01-02 21:19:43 CET
OK, thanks very much; that worked (with GTK+ 2.4 even!).  Mucking around the 
code for icon names is not one of my specialties. ;P

And again, thanks for a nice player!

Bug #476

Reported by:
Andrew Conkling
Reported on: 2004-11-07
Last modified on: 2005-01-02

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information